Issue 345037: Fifth patch in getting rid of caching MessageLoop pointers.

Issue 345037: Fifth patch in getting rid of caching MessageLoop pointers. (Closed)

Created:
11 years, 1 month ago by jam

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5)

CC:
chromium-reviews_googlegroups.com, kuchhal, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fifth patch in getting rid of caching MessageLoop pointers. BUG=25354 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30790

Patch Set 1 : '' #

Total comments: 6

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+365 lines, -395 lines)			Patch
M	chrome/browser/automation/url_request_automation_job.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/browser_init.cc	View	3 chunks	+9 lines, -7 lines	2 comments	Download
M	chrome/browser/browsing_data_remover.h	View	1 chunk	+1 line, -2 lines	2 comments	Download
M	chrome/browser/browsing_data_remover.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/chrome_thread.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	chrome/browser/chrome_thread.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/google_update.cc	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/importer/importer.h	View	3 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/importer/importer.cc	View	5 chunks	+3 lines, -18 lines	0 comments	Download
MM	chrome/browser/importer/importer_bridge.h	View	4 chunks	+0 lines, -6 lines	0 comments	Download
MM	chrome/browser/importer/importer_bridge.cc	View	2 chunks	+39 lines, -28 lines	0 comments	Download
M	chrome/browser/importer/importer_unittest.cc	View	6 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/browser/importer/toolbar_importer.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	chrome/browser/jumplist.cc	View	2 chunks	+5 lines, -7 lines	0 comments	Download
M	chrome/browser/login_prompt.h	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/login_prompt.cc	View	2 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/login_prompt_gtk.cc	View	13 chunks	+45 lines, -44 lines	0 comments	Download
M	chrome/browser/login_prompt_mac.mm	View	11 chunks	+46 lines, -45 lines	0 comments	Download
M	chrome/browser/login_prompt_win.cc	View	12 chunks	+43 lines, -43 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_dispatcher_host.cc	View	3 chunks	+3 lines, -3 lines	2 comments	Download
M	chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc	View	2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/shell_integration.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/shell_integration.cc	View	3 chunks	+22 lines, -18 lines	0 comments	Download
MM	chrome/browser/ssl/ssl_cert_error_handler.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
MM	chrome/browser/ssl/ssl_cert_error_handler.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/ssl/ssl_client_auth_handler.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/ssl/ssl_client_auth_handler.cc	View	3 chunks	+10 lines, -11 lines	0 comments	Download
MM	chrome/browser/ssl/ssl_error_handler.h	View	3 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/ssl/ssl_error_handler.cc	View	8 chunks	+33 lines, -29 lines	0 comments	Download
M	chrome/browser/ssl/ssl_manager.h	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ssl/ssl_manager.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/tab_contents/interstitial_page.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/interstitial_page.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/web_contents_unittest.cc	View	3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/task_manager.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/task_manager.cc	View	2 chunks	+9 lines, -9 lines	0 comments	Download
M	chrome/browser/task_manager_resource_providers.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/task_manager_resource_providers.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/views/shell_dialogs_win.cc	View	6 chunks	+35 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

lgtm and the code is much more readable. Below some nits. Submit when ready. http://codereview.chromium.org/345037/diff/3042/3062 ...

11 years, 1 month ago (2009-11-03 02:16:24 UTC) #2

jam

11 years, 1 month ago (2009-11-03 03:52:46 UTC) #3

http://codereview.chromium.org/345037/diff/3042/3062
File chrome/browser/browser_init.cc (right):

http://codereview.chromium.org/345037/diff/3042/3062#newcode189
Line 189: 
On 2009/11/03 02:16:24, cpu wrote:
> remove blank line?

Done.

http://codereview.chromium.org/345037/diff/3042/3076
File chrome/browser/browsing_data_remover.h (right):

http://codereview.chromium.org/345037/diff/3042/3076#newcode13
Line 13: class MessageLoop;
On 2009/11/03 02:16:24, cpu wrote:
> remove MessageLoop

Done.

http://codereview.chromium.org/345037/diff/3042/3075
File chrome/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/345037/diff/3042/3075#newcode12
Line 12: #include "base/message_loop.h"
On 2009/11/03 02:16:24, cpu wrote:
> so that include is not needed?

for just a little bit longer, since we do MessageLoop::current().  Will remove
soon when it's not used anymore

Expand Messages | Collapse Messages