chrome/browser/ssl/ssl_manager.cc - Issue 345037: Fifth patch in getting rid of caching MessageLoop pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ssl/ssl_manager.cc

Issue 345037: Fifth patch in getting rid of caching MessageLoop pointers. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/renderer_host/resource_dispatcher_host.cc ('K') | « chrome/browser/ssl/ssl_manager.h ('k') | chrome/browser/tab_contents/interstitial_page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ssl/ssl_manager.cc

===================================================================

--- chrome/browser/ssl/ssl_manager.cc (revision 30691)

+++ chrome/browser/ssl/ssl_manager.cc (working copy)

@@ -5,7 +5,7 @@

#include "chrome/browser/ssl/ssl_manager.h"

#include "app/l10n_util.h"

-#include "base/message_loop.h"

+#include "chrome/browser/chrome_thread.h"

#include "chrome/browser/load_from_memory_cache_details.h"

#include "chrome/browser/net/url_request_tracking.h"

#include "chrome/browser/renderer_host/resource_request_details.h"

@@ -63,8 +63,7 @@

void SSLManager::OnSSLCertificateError(ResourceDispatcherHost* rdh,

URLRequest* request,

int cert_error,

- net::X509Certificate* cert,

- MessageLoop* ui_loop) {

+ net::X509Certificate* cert) {

DLOG(INFO) << "OnSSLCertificateError() cert_error: " << cert_error <<

" url: " << request->url().spec();

@@ -74,15 +73,15 @@

// A certificate error occurred. Construct a SSLCertErrorHandler object and

// hand it over to the UI thread for processing.

- ui_loop->PostTask(FROM_HERE,

+ ChromeThread::PostTask(

+ ChromeThread::UI, FROM_HERE,

NewRunnableMethod(new SSLCertErrorHandler(rdh,

request,

info->resource_type(),

info->frame_origin(),

info->main_frame_origin(),

cert_error,

- cert,

- ui_loop),

+ cert),

&SSLCertErrorHandler::Dispatch));

}