Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9061)

Unified Diff: chrome/browser/browser_init.cc

Issue 345037: Fifth patch in getting rid of caching MessageLoop pointers. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_init.cc
===================================================================
--- chrome/browser/browser_init.cc (revision 30691)
+++ chrome/browser/browser_init.cc (working copy)
@@ -9,11 +9,11 @@
#include "base/event_recorder.h"
#include "base/path_service.h"
#include "base/sys_info.h"
-#include "base/thread.h"
#include "chrome/browser/automation/automation_provider.h"
#include "chrome/browser/browser_list.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/browser_window.h"
+#include "chrome/browser/chrome_thread.h"
#include "chrome/browser/defaults.h"
#include "chrome/browser/extensions/extension_creator.h"
#include "chrome/browser/first_run.h"
@@ -174,16 +174,18 @@
class CheckDefaultBrowserTask : public Task {
public:
- explicit CheckDefaultBrowserTask(MessageLoop* ui_loop) : ui_loop_(ui_loop) {
+ CheckDefaultBrowserTask() {
}
virtual void Run() {
- if (!ShellIntegration::IsDefaultBrowser())
- ui_loop_->PostTask(FROM_HERE, new NotifyNotDefaultBrowserTask());
+ if (ShellIntegration::IsDefaultBrowser())
+ return;
+
+ ChromeThread::PostTask(
+ ChromeThread::UI, FROM_HERE, new NotifyNotDefaultBrowserTask());
}
private:
- MessageLoop* ui_loop_;
cpu_(ooo_6.6-7.5) 2009/11/03 02:16:24 remove blank line?
jam 2009/11/03 03:52:47 Done.
DISALLOW_COPY_AND_ASSIGN(CheckDefaultBrowserTask);
};
@@ -674,8 +676,8 @@
FirstRun::IsChromeFirstRun()) {
return;
}
- g_browser_process->file_thread()->message_loop()->PostTask(FROM_HERE,
- new CheckDefaultBrowserTask(MessageLoop::current()));
+ ChromeThread::PostTask(
+ ChromeThread::FILE, FROM_HERE, new CheckDefaultBrowserTask());
}
bool BrowserInit::ProcessCmdLineImpl(const CommandLine& command_line,

Powered by Google App Engine
This is Rietveld 408576698