Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 345016: Add checkbins.py step to Chromium XP bot and Google Chrome FYI bot.... (Closed)

Created:
11 years, 1 month ago by scherkus (not reviewing)
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com, Nicolas Sylvain, pam+watch_chromium.org
Visibility:
Public.

Description

Add checkbins.py step to Chromium XP bot and Google Chrome FYI bot. BUG=25952 TEST=bots don't break!

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M master.chromium.fyi/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M master.chromium/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M scripts/master/factory/chromium_commands.py View 1 2 chunks +5 lines, -0 lines 0 comments Download
M scripts/master/factory/chromium_factory.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scherkus (not reviewing)
UNTESTED!!! I was about to follow the steps at http://dev.chromium.org/developers/testing/chromium-build-infrastructure/running-a-buildbot-instance but I'm scared of completely ...
11 years, 1 month ago (2009-10-28 19:49:08 UTC) #1
M-A Ruel
lgtm
11 years, 1 month ago (2009-10-28 19:57:02 UTC) #2
Nicolas Sylvain
maybe the try bots should run that too? On Wed, Oct 28, 2009 at 12:57 ...
11 years, 1 month ago (2009-10-28 19:58:31 UTC) #3
M-A Ruel
On 2009/10/28 19:58:31, Nicolas Sylvain wrote: > maybe the try bots should run that too? ...
11 years, 1 month ago (2009-10-28 20:05:17 UTC) #4
Nicolas Sylvain
On Wed, Oct 28, 2009 at 1:05 PM, <maruel@chromium.org> wrote: > On 2009/10/28 19:58:31, Nicolas ...
11 years, 1 month ago (2009-10-28 20:07:46 UTC) #5
scherkus (not reviewing)
holding off on this change until NaCl and some other components can pass the test ...
11 years, 1 month ago (2009-10-28 22:35:52 UTC) #6
scherkus (not reviewing)
11 years, 1 month ago (2009-10-30 21:25:14 UTC) #7
plan of attack is to make the tool always succeed:
http://codereview.chromium.org/343068/show

and then I can collect failure data and fix those binaries

security++

Powered by Google App Engine
This is Rietveld 408576698