Add checkbins.py step to Chromium XP bot and Google Chrome FYI bot....

scripts/master/factory/chromium_commands.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Set of utilities to add commands to a buildbot factory.
 
 This is based on commands.py and adds chromium-specific commands."""
 
 import logging
@@ skipping 379 matching lines @@
     self._dom_perf_tool = J(s_dir, 'dom_perf.py')
     self._archive_tool = J(s_dir, 'archive_build.py')
     self._sizes_tool = J(s_dir, 'sizes.py')
 
     # Scripts in the private dir.
     self._reliability_tool = J(p_dir, 'reliability_tests.py')
     self._reliability_data = J(p_dir, 'data', 'reliability')
 
     # These scripts should be move to the script dir.
     self._check_deps_tool = J('src', 'tools', 'checkdeps', 'checkdeps.py')
+    self._check_bins_tool = J('src', 'tools', 'checkbins', 'checkbins.py')
     self._valgrind_tool = J('src', 'tools', 'valgrind', 'chrome_tests.sh')
     self._purify_tool = J('src', 'tools', 'purify', 'chrome_tests.py')
 
     # chrome_staging directory, relative to the build directory.
     self._staging_dir = self.PathJoin('..', 'chrome_staging')
 
     # The _update_scripts_command will be run in the _update_scripts_dir to
     # udpate the slave's own script checkout.
     self._update_scripts_dir = '..'
     self._update_scripts_command = [
@@ skipping 43 matching lines @@
       cmd.extend(['--extra-archive-paths', extra_archive_paths])
 
     self.AddArchiveStep(data_description='build', base_url=url, link_text=text,
                         command=cmd)
 
   def AddCheckDepsStep(self):
     cmd = [self._python, self._check_deps_tool,
            '--root', self._repository_root]
     self.AddTestStep(shell.ShellCommand, 'check deps', cmd)
 
+  def AddCheckBinsStep(self):
+    cmd = [self._python, self._check_bins_tool, self._build_dir]
+    self.AddTestStep(shell.ShellCommand, 'check bins', cmd)
+
   def GetPageCyclerTestClass(self, factory_properties, test_name):
     """Selects the right build step for the specified page-cycler test."""
     factory_properties = factory_properties or {}
     perf_id = factory_properties.get('perf_id')
     show_results = factory_properties.get('show_perf_results')
     http = factory_properties.get('http_page_cyclers')
 
     report_link = None
     output_dir = None
     perf_name = None
@@ skipping 430 matching lines @@
 
     url = '%s/%s/%s' %  (self._archive_url, 'coverage', perf_subdir)
     text = 'view coverage'
     cmd_archive = [self._python, self._archive_coverage,
            '--target', self._target,
            '--build-dir', self._build_dir,
            '--perf-subdir', perf_subdir]
 
     self.AddArchiveStep(data_description='coverage', base_url=url,
                         link_text=text, command=cmd_archive)