Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: scripts/master/factory/chromium_commands.py

Issue 345016: Add checkbins.py step to Chromium XP bot and Google Chrome FYI bot.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/tools/buildbot/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « master.chromium/master.cfg ('k') | scripts/master/factory/chromium_factory.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/chromium_commands.py
===================================================================
--- scripts/master/factory/chromium_commands.py (revision 30360)
+++ scripts/master/factory/chromium_commands.py (working copy)
@@ -397,6 +397,7 @@
# These scripts should be move to the script dir.
self._check_deps_tool = J('src', 'tools', 'checkdeps', 'checkdeps.py')
+ self._check_bins_tool = J('src', 'tools', 'checkbins', 'checkbins.py')
self._valgrind_tool = J('src', 'tools', 'valgrind', 'chrome_tests.sh')
self._purify_tool = J('src', 'tools', 'purify', 'chrome_tests.py')
@@ -460,6 +461,10 @@
'--root', self._repository_root]
self.AddTestStep(shell.ShellCommand, 'check deps', cmd)
+ def AddCheckBinsStep(self):
+ cmd = [self._python, self._check_bins_tool, self._build_dir]
+ self.AddTestStep(shell.ShellCommand, 'check bins', cmd)
+
def GetPageCyclerTestClass(self, factory_properties, test_name):
"""Selects the right build step for the specified page-cycler test."""
factory_properties = factory_properties or {}
« no previous file with comments | « master.chromium/master.cfg ('k') | scripts/master/factory/chromium_factory.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698