Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 344833002: Oilpan: move MessagePortArray to the heap. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, arv+blink, tzik, eae+blinkwatch, kinuko+serviceworker, nhiroki, abarth-chromium, falken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, kinuko+worker_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Oilpan: move MessagePortArray to the heap. Complete the addition of Oilpan transition types for MessagePort, and also move its array type to the heap. R=haraken@chromium.org,adamk@chromium.org BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176591

Patch Set 1 #

Patch Set 2 : Fix (non-)tracing of an OwnPtr to a non-GCed object #

Patch Set 3 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -34 lines) Patch
M Source/bindings/v8/Dictionary.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/SerializedScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/SerializedScriptValue.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8MessageEventCustom.cpp View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/MessagePort.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
M Source/core/events/MessageEvent.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/events/MessageEvent.cpp View 1 2 5 chunks +8 lines, -5 lines 0 comments Download
M Source/core/frame/LocalDOMWindow.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebDOMMessageEvent.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (0 generated)
sof
Please take a look. (Still waiting for verification from a complete Oilpan trybot run.)
6 years, 6 months ago (2014-06-19 13:50:57 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-19 15:31:51 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-19 16:45:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/344833002/10001
6 years, 6 months ago (2014-06-19 16:46:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 17:44:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/8034)
6 years, 6 months ago (2014-06-19 17:44:03 UTC) #6
sof
Source/web/ changes needs separate approval
6 years, 6 months ago (2014-06-19 20:02:12 UTC) #7
adamk
lgtm for Source/web
6 years, 6 months ago (2014-06-19 20:39:12 UTC) #8
sof
On 2014/06/19 20:39:12, adamk wrote: > lgtm for Source/web many thanks.
6 years, 6 months ago (2014-06-19 21:05:26 UTC) #9
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-19 21:05:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/344833002/10001
6 years, 6 months ago (2014-06-19 21:06:15 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 21:08:21 UTC) #12
commit-bot: I haz the power
Failed to apply patch for Source/bindings/v8/custom/V8MessageEventCustom.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-19 21:08:22 UTC) #13
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-19 21:42:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/344833002/30001
6 years, 6 months ago (2014-06-19 21:43:08 UTC) #15
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-19 23:04:51 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 23:43:48 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12770)
6 years, 6 months ago (2014-06-19 23:43:49 UTC) #18
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-20 01:24:05 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/344833002/30001
6 years, 6 months ago (2014-06-20 01:24:50 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-20 02:42:51 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-20 03:41:11 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/12798)
6 years, 6 months ago (2014-06-20 03:41:13 UTC) #23
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-20 05:00:13 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/344833002/30001
6 years, 6 months ago (2014-06-20 05:00:49 UTC) #25
sof
The CQ bit was unchecked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-20 05:05:20 UTC) #26
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-20 05:16:16 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/344833002/30001
6 years, 6 months ago (2014-06-20 05:17:07 UTC) #28
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 05:47:16 UTC) #29
Message was sent while issue was closed.
Change committed as 176591

Powered by Google App Engine
This is Rietveld 408576698