Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: Source/bindings/v8/custom/V8MessageEventCustom.cpp

Issue 344833002: Oilpan: move MessagePortArray to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/core/dom/MessagePort.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 125 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 void V8MessageEvent::initMessageEventMethodCustom(const v8::FunctionCallbackInfo <v8::Value>& info) 136 void V8MessageEvent::initMessageEventMethodCustom(const v8::FunctionCallbackInfo <v8::Value>& info)
137 { 137 {
138 MessageEvent* event = V8MessageEvent::toNative(info.Holder()); 138 MessageEvent* event = V8MessageEvent::toNative(info.Holder());
139 TOSTRING_VOID(V8StringResource<>, typeArg, info[0]); 139 TOSTRING_VOID(V8StringResource<>, typeArg, info[0]);
140 TONATIVE_VOID(bool, canBubbleArg, info[1]->BooleanValue()); 140 TONATIVE_VOID(bool, canBubbleArg, info[1]->BooleanValue());
141 TONATIVE_VOID(bool, cancelableArg, info[2]->BooleanValue()); 141 TONATIVE_VOID(bool, cancelableArg, info[2]->BooleanValue());
142 v8::Handle<v8::Value> dataArg = info[3]; 142 v8::Handle<v8::Value> dataArg = info[3];
143 TOSTRING_VOID(V8StringResource<>, originArg, info[4]); 143 TOSTRING_VOID(V8StringResource<>, originArg, info[4]);
144 TOSTRING_VOID(V8StringResource<>, lastEventIdArg, info[5]); 144 TOSTRING_VOID(V8StringResource<>, lastEventIdArg, info[5]);
145 LocalDOMWindow* sourceArg = toDOMWindow(info[6], info.GetIsolate()); 145 LocalDOMWindow* sourceArg = toDOMWindow(info[6], info.GetIsolate());
146 OwnPtr<MessagePortArray> portArray; 146 OwnPtrWillBeRawPtr<MessagePortArray> portArray = nullptr;
147 const int portArrayIndex = 7; 147 const int portArrayIndex = 7;
148 if (!isUndefinedOrNull(info[portArrayIndex])) { 148 if (!isUndefinedOrNull(info[portArrayIndex])) {
149 portArray = adoptPtr(new MessagePortArray); 149 portArray = adoptPtrWillBeNoop(new MessagePortArray);
150 bool success = false; 150 bool success = false;
151 *portArray = toRefPtrNativeArray<MessagePort, V8MessagePort>(info[portAr rayIndex], portArrayIndex + 1, info.GetIsolate(), &success); 151 *portArray = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort> (info[portArrayIndex], portArrayIndex + 1, info.GetIsolate(), &success);
152 if (!success) 152 if (!success)
153 return; 153 return;
154 } 154 }
155 event->initMessageEvent(typeArg, canBubbleArg, cancelableArg, originArg, las tEventIdArg, sourceArg, portArray.release()); 155 event->initMessageEvent(typeArg, canBubbleArg, cancelableArg, originArg, las tEventIdArg, sourceArg, portArray.release());
156 156
157 if (!dataArg.IsEmpty()) { 157 if (!dataArg.IsEmpty()) {
158 V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8Hidden Value::data(info.GetIsolate()), dataArg); 158 V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8Hidden Value::data(info.GetIsolate()), dataArg);
159 if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld()) 159 if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld())
160 event->setSerializedData(SerializedScriptValue::createAndSwallowExce ptions(dataArg, info.GetIsolate())); 160 event->setSerializedData(SerializedScriptValue::createAndSwallowExce ptions(dataArg, info.GetIsolate()));
161 } 161 }
162 } 162 }
163 163
164 } // namespace WebCore 164 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8Binding.h ('k') | Source/core/dom/MessagePort.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698