Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Side by Side Diff: Source/bindings/v8/Dictionary.cpp

Issue 344833002: Oilpan: move MessagePortArray to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/SerializedScriptValue.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
343 { 343 {
344 v8::Local<v8::Value> v8Value; 344 v8::Local<v8::Value> v8Value;
345 if (!getKey(key, v8Value)) 345 if (!getKey(key, v8Value))
346 return false; 346 return false;
347 347
348 ASSERT(m_isolate); 348 ASSERT(m_isolate);
349 ASSERT(m_isolate == v8::Isolate::GetCurrent()); 349 ASSERT(m_isolate == v8::Isolate::GetCurrent());
350 if (WebCore::isUndefinedOrNull(v8Value)) 350 if (WebCore::isUndefinedOrNull(v8Value))
351 return true; 351 return true;
352 bool success = false; 352 bool success = false;
353 value = toRefPtrNativeArray<MessagePort, V8MessagePort>(v8Value, key, m_isol ate, &success); 353 value = toRefPtrWillBeMemberNativeArray<MessagePort, V8MessagePort>(v8Value, key, m_isolate, &success);
354 return success; 354 return success;
355 } 355 }
356 356
357 bool Dictionary::convert(ConversionContext& context, const String& key, MessageP ortArray& value) const 357 bool Dictionary::convert(ConversionContext& context, const String& key, MessageP ortArray& value) const
358 { 358 {
359 ConversionContextScope scope(context); 359 ConversionContextScope scope(context);
360 360
361 v8::Local<v8::Value> v8Value; 361 v8::Local<v8::Value> v8Value;
362 if (!getKey(key, v8Value)) 362 if (!getKey(key, v8Value))
363 return true; 363 return true;
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
735 735
736 return *this; 736 return *this;
737 } 737 }
738 738
739 void Dictionary::ConversionContext::throwTypeError(const String& detail) 739 void Dictionary::ConversionContext::throwTypeError(const String& detail)
740 { 740 {
741 exceptionState().throwTypeError(detail); 741 exceptionState().throwTypeError(detail);
742 } 742 }
743 743
744 } // namespace WebCore 744 } // namespace WebCore
OLDNEW
« no previous file with comments | « no previous file | Source/bindings/v8/SerializedScriptValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698