Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 344653003: Revert 274608 "Implement getMediaDevices." (Closed)

Created:
6 years, 6 months ago by amineer_google
Modified:
6 years, 6 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, asvitkine+watch_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert 274608 "Implement getMediaDevices." Reverting to determine if flash crashes go away per findings on bug thread > Implement getMediaDevices. > > * Hook up two new function in the blink interface WebUserMediaClient in MediaStreamImpl through MediaStreamDispatcher to MediaStreamManager to enumerate audio and video input devices. > * Produces the same result as the current getSources API. > * The blink interface will be landed after this CL and browser test after that. > * Add audio output devices and group ID support is done in another CL. > > BUG=338511 > > Review URL: https://codereview.chromium.org/287383002 TBR=grunell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -428 lines) Patch
M content/browser/renderer_host/media/device_request_message_filter.cc View 3 chunks +17 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/device_request_message_filter_unittest.cc View 7 chunks +52 lines, -10 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 3 chunks +1 line, -6 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 2 chunks +3 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 4 chunks +4 lines, -51 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 11 chunks +1 line, -25 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_impl.h View 6 chunks +1 line, -19 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 6 chunks +3 lines, -172 lines 0 comments Download
M content/renderer/media/media_stream_impl_unittest.cc View 12 chunks +7 lines, -52 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.h View 2 chunks +2 lines, -12 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 3 chunks +17 lines, -43 lines 0 comments Download
M content/renderer/media/webrtc_uma_histograms.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/webrtc_uma_histograms_unittest.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
amineer_google
6 years, 6 months ago (2014-06-18 21:01:54 UTC) #1
amineer_google
Committed patchset #1 manually as r278174.
6 years, 6 months ago (2014-06-18 21:02:32 UTC) #2
Henrik Grunell
6 years, 6 months ago (2014-06-23 08:51:35 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698