Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: content/browser/renderer_host/media/media_stream_manager.cc

Issue 344653003: Revert 274608 "Implement getMediaDevices." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2057/src/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/media_stream_manager.cc
===================================================================
--- content/browser/renderer_host/media/media_stream_manager.cc (revision 278172)
+++ content/browser/renderer_host/media/media_stream_manager.cc (working copy)
@@ -161,15 +161,6 @@
return std::string();
}
-// Clears the MediaStreamDevice.name from all devices in |devices|.
-static void ClearDeviceLabels(content::StreamDeviceInfoArray* devices) {
- for (content::StreamDeviceInfoArray::iterator device_itr = devices->begin();
- device_itr != devices->end();
- ++device_itr) {
- device_itr->device.name.clear();
- }
-}
-
} // namespace
@@ -186,7 +177,6 @@
int requesting_view_id,
int page_request_id,
const GURL& security_origin,
- bool have_permission,
bool user_gesture,
MediaStreamRequestType request_type,
const StreamOptions& options,
@@ -196,7 +186,6 @@
requesting_view_id(requesting_view_id),
page_request_id(page_request_id),
security_origin(security_origin),
- have_permission(have_permission),
user_gesture(user_gesture),
request_type(request_type),
options(options),
@@ -318,10 +307,6 @@
const GURL security_origin;
- // This is used when enumerating devices; if we don't have device access
- // permission, we remove the device label.
- bool have_permission;
-
const bool user_gesture;
const MediaStreamRequestType request_type;
@@ -426,7 +411,6 @@
render_view_id,
page_request_id,
security_origin,
- true,
false, // user gesture
MEDIA_DEVICE_ACCESS,
options,
@@ -467,7 +451,6 @@
render_view_id,
page_request_id,
security_origin,
- true,
user_gesture,
MEDIA_GENERATE_STREAM,
options,
@@ -650,8 +633,7 @@
const ResourceContext::SaltCallback& sc,
int page_request_id,
MediaStreamType type,
- const GURL& security_origin,
- bool have_permission) {
+ const GURL& security_origin) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK(requester);
DCHECK(type == MEDIA_DEVICE_AUDIO_CAPTURE ||
@@ -662,7 +644,6 @@
render_view_id,
page_request_id,
security_origin,
- have_permission,
false, // user gesture
MEDIA_ENUMERATE_DEVICES,
StreamOptions(),
@@ -699,7 +680,6 @@
cache = &audio_enumeration_cache_;
} else {
DCHECK_EQ(MEDIA_DEVICE_VIDEO_CAPTURE, request->video_type());
- DCHECK_EQ(MEDIA_NO_SERVICE, request->audio_type());
type = MEDIA_DEVICE_VIDEO_CAPTURE;
cache = &video_enumeration_cache_;
}
@@ -744,7 +724,6 @@
render_view_id,
page_request_id,
security_origin,
- true,
false, // user gesture
MEDIA_OPEN_DEVICE,
options,
@@ -1396,9 +1375,6 @@
request->devices.clear();
}
- if (!request->have_permission)
- ClearDeviceLabels(&request->devices);
-
request->requester->DevicesEnumerated(
request->requesting_view_id,
request->page_request_id,

Powered by Google App Engine
This is Rietveld 408576698