Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 287383002: Implement getMediaDevices. (Closed)

Created:
6 years, 7 months ago by Henrik Grunell
Modified:
6 years, 6 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Visibility:
Public.

Description

Implement getMediaDevices. * Hook up two new function in the blink interface WebUserMediaClient in MediaStreamImpl through MediaStreamDispatcher to MediaStreamManager to enumerate audio and video input devices. * Produces the same result as the current getSources API. * The blink interface will be landed after this CL and browser test after that. * Add audio output devices and group ID support is done in another CL. BUG=338511 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274608

Patch Set 1 #

Patch Set 2 : Updates #

Patch Set 3 : Don't clear labels in DRMF. #

Total comments: 30

Patch Set 4 : Code review. #

Patch Set 5 : Removed StopEnumerateDevices in pepper. #

Total comments: 7

Patch Set 6 : Tests. #

Patch Set 7 : Code review fix, a minor test refactoring. And rebase, sorry. #

Total comments: 20

Patch Set 8 : Code review fixes, added UMA, rebase. #

Patch Set 9 : Added enum value in histograms.xml. #

Patch Set 10 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -113 lines) Patch
M content/browser/renderer_host/media/device_request_message_filter.cc View 1 2 3 4 5 6 3 chunks +4 lines, -17 lines 0 comments Download
M content/browser/renderer_host/media/device_request_message_filter_unittest.cc View 1 2 3 4 5 7 chunks +10 lines, -52 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 1 2 3 4 5 6 7 3 chunks +6 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 2 3 4 5 6 7 2 chunks +11 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 2 3 4 5 4 chunks +51 lines, -4 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 2 3 4 5 6 7 8 9 11 chunks +25 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_dispatcher.h View 1 2 3 4 5 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_impl.h View 1 2 3 4 5 6 chunks +19 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_impl.cc View 1 2 3 4 5 6 7 6 chunks +172 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_impl_unittest.cc View 1 2 3 4 5 12 chunks +52 lines, -7 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.h View 1 2 3 4 5 6 2 chunks +12 lines, -2 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 1 2 3 4 5 6 3 chunks +43 lines, -17 lines 0 comments Download
M content/renderer/media/webrtc_uma_histograms.h View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/webrtc_uma_histograms_unittest.cc View 1 2 3 4 5 6 7 1 chunk +13 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
Henrik Grunell
Please take a first look. I let MSM do label removal, and DRMF needs to ...
6 years, 7 months ago (2014-05-27 09:38:53 UTC) #1
perkj_chrome
https://codereview.chromium.org/287383002/diff/40001/content/browser/renderer_host/media/device_request_message_filter.cc File content/browser/renderer_host/media/device_request_message_filter.cc (right): https://codereview.chromium.org/287383002/diff/40001/content/browser/renderer_host/media/device_request_message_filter.cc#newcode135 content/browser/renderer_host/media/device_request_message_filter.cc:135: MEDIA_DEVICE_AUDIO_CAPTURE, security_origin, resource_context_); I think Joi has big problems ...
6 years, 7 months ago (2014-05-27 11:57:23 UTC) #2
mcasas
https://codereview.chromium.org/287383002/diff/40001/content/browser/renderer_host/media/media_stream_manager.cc File content/browser/renderer_host/media/media_stream_manager.cc (right): https://codereview.chromium.org/287383002/diff/40001/content/browser/renderer_host/media/media_stream_manager.cc#newcode164 content/browser/renderer_host/media/media_stream_manager.cc:164: // Clears the MediaStreamDevice.name from all devices in |device_list|. ...
6 years, 7 months ago (2014-05-27 12:08:22 UTC) #3
Henrik Grunell
Adding David as reviewer. I removed the device change notification via the request - the ...
6 years, 7 months ago (2014-05-27 15:33:54 UTC) #4
dmichael (off chromium)
https://codereview.chromium.org/287383002/diff/80001/content/renderer/pepper/pepper_device_enumeration_host_helper.cc File content/renderer/pepper/pepper_device_enumeration_host_helper.cc (right): https://codereview.chromium.org/287383002/diff/80001/content/renderer/pepper/pepper_device_enumeration_host_helper.cc#newcode56 content/renderer/pepper/pepper_device_enumeration_host_helper.cc:56: ~ScopedRequest() {} Another thing this was doing was canceling ...
6 years, 7 months ago (2014-05-27 20:43:22 UTC) #5
Henrik Grunell
I have also updated the tests locally, and am adding tests for MediaStreamImpl. It requires ...
6 years, 7 months ago (2014-05-28 11:08:26 UTC) #6
perkj_chrome
This looks good. I think you should take some of the test in device_messsage_filter_unittests and ...
6 years, 6 months ago (2014-05-28 14:49:14 UTC) #7
dmichael (off chromium)
https://codereview.chromium.org/287383002/diff/80001/content/renderer/pepper/pepper_device_enumeration_host_helper.cc File content/renderer/pepper/pepper_device_enumeration_host_helper.cc (right): https://codereview.chromium.org/287383002/diff/80001/content/renderer/pepper/pepper_device_enumeration_host_helper.cc#newcode56 content/renderer/pepper/pepper_device_enumeration_host_helper.cc:56: ~ScopedRequest() {} On 2014/05/28 11:08:27, Henrik Grunell wrote: > ...
6 years, 6 months ago (2014-05-28 15:08:36 UTC) #8
Henrik Grunell
Yes I meant putting the stop back in the dtor. With remove notification service I ...
6 years, 6 months ago (2014-05-28 19:16:42 UTC) #9
dmichael (off chromium)
I'm not very familiar with that code, but it looks to me like the following ...
6 years, 6 months ago (2014-05-28 20:11:33 UTC) #10
Henrik Grunell
On 2014/05/28 20:11:33, dmichael wrote: > I'm not very familiar with that code, but it ...
6 years, 6 months ago (2014-05-29 18:12:32 UTC) #11
dmichael (off chromium)
On Thu, May 29, 2014 at 12:12 PM, <grunell@chromium.org> wrote: > On 2014/05/28 20:11:33, dmichael ...
6 years, 6 months ago (2014-05-29 19:06:49 UTC) #12
Henrik Grunell
Added and updated tests. PTAL.
6 years, 6 months ago (2014-05-30 15:21:38 UTC) #13
Henrik Grunell
I suspect Per is now ooo. Adding Shijing for */media/* (basically everything). Per has reviewed ...
6 years, 6 months ago (2014-06-02 08:19:47 UTC) #14
no longer working on chromium
https://codereview.chromium.org/287383002/diff/120001/content/browser/renderer_host/media/media_stream_dispatcher_host.cc File content/browser/renderer_host/media/media_stream_dispatcher_host.cc (right): https://codereview.chromium.org/287383002/diff/120001/content/browser/renderer_host/media/media_stream_dispatcher_host.cc#newcode183 content/browser/renderer_host/media/media_stream_dispatcher_host.cc:183: bool have_permission = type == MEDIA_DEVICE_AUDIO_CAPTURE ? will type ...
6 years, 6 months ago (2014-06-02 11:57:41 UTC) #15
sky
content/browser/renderer_host/render_process_host_impl.cc LGTM
6 years, 6 months ago (2014-06-02 14:46:39 UTC) #16
Henrik Grunell
Code review fixes, added UMA. https://codereview.chromium.org/287383002/diff/120001/content/browser/renderer_host/media/media_stream_dispatcher_host.cc File content/browser/renderer_host/media/media_stream_dispatcher_host.cc (right): https://codereview.chromium.org/287383002/diff/120001/content/browser/renderer_host/media/media_stream_dispatcher_host.cc#newcode183 content/browser/renderer_host/media/media_stream_dispatcher_host.cc:183: bool have_permission = type ...
6 years, 6 months ago (2014-06-03 07:52:27 UTC) #17
Henrik Grunell
Adding Alexei for tools/metrics/histograms/histograms.xml
6 years, 6 months ago (2014-06-03 08:13:55 UTC) #18
no longer working on chromium
On 2014/06/03 08:13:55, Henrik Grunell wrote: > Adding Alexei for tools/metrics/histograms/histograms.xml lgtm
6 years, 6 months ago (2014-06-03 08:53:21 UTC) #19
Alexei Svitkine (slow)
histograms lgtm
6 years, 6 months ago (2014-06-03 14:25:31 UTC) #20
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 6 months ago (2014-06-03 14:53:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/287383002/170001
6 years, 6 months ago (2014-06-03 14:53:25 UTC) #22
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-03 18:31:34 UTC) #23
commit-bot: I haz the power
6 years, 6 months ago (2014-06-03 20:35:11 UTC) #24
Message was sent while issue was closed.
Change committed as 274608

Powered by Google App Engine
This is Rietveld 408576698