Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issue 344233006: Remove special case gpu transforms for Identity and Translate (Closed)

Created:
6 years, 6 months ago by egdaniel
Modified:
6 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove special case gpu transforms for Identity and Translate Change will remove some special cases for coord transforms in favor of not needing to compile a new program if the coord trans changes from one special case to another. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4c6443e86927c8cbf794d7c154470b9675aa7778

Patch Set 1 #

Patch Set 2 : Remove unused function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -127 lines) Patch
M src/gpu/gl/GrGLProgramEffects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLProgramEffects.cpp View 1 9 chunks +24 lines, -126 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
egdaniel
6 years, 6 months ago (2014-06-24 19:25:39 UTC) #1
bsalomon
lgtm. Any chance this changes GMs ever so slightly?
6 years, 6 months ago (2014-06-24 20:02:02 UTC) #2
bsalomon
On 2014/06/24 20:02:02, bsalomon wrote: > lgtm. Any chance this changes GMs ever so slightly? ...
6 years, 6 months ago (2014-06-24 20:02:32 UTC) #3
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 6 months ago (2014-06-24 20:10:23 UTC) #4
egdaniel
The CQ bit was unchecked by egdaniel@google.com
6 years, 6 months ago (2014-06-24 20:10:23 UTC) #5
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 6 months ago (2014-06-24 20:10:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/344233006/1
6 years, 6 months ago (2014-06-24 20:11:02 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia ...
6 years, 6 months ago (2014-06-24 20:25:42 UTC) #8
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 6 months ago (2014-06-24 20:27:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/344233006/20001
6 years, 6 months ago (2014-06-24 20:28:22 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 20:43:17 UTC) #11
Message was sent while issue was closed.
Change committed as 4c6443e86927c8cbf794d7c154470b9675aa7778

Powered by Google App Engine
This is Rietveld 408576698