Allow git cl also in repos with read-only git-svn.

Allow git cl also in repos with read-only git-svn.

If you have read-only git-svn git cl would still try
to use svn commands, which would then fail. This
changes git cl to only use git-svn if the remote
svn repository use the svn:// protocol. It matches
how chromium works and it allowed me to upload a patch.

BUG=391430
R=iannucci

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=281500

[Daniel Bratell, 2014-06-30 15:17:32]

iannucci, can you please take a look at this patch? It was something I had to do
after adding (read only) release branches to my repository to be able to still
upload patched with git cl.

[iannucci, 2014-06-30 18:08:11]

https://codereview.chromium.org/344013005/diff/1/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/344013005/diff/1/git_cl.py#newcode330
git_cl.py:330: # If you have any "svn-remote.*" config keys, we think you're
using svn.
can you update the comment too? Something like:

If you have any svn-remote with a url using the svn:// protocol, we think you're
using svn. We assume that http* protocols indicate a read-only svn remote.


ick... I felt bad writing that :(

[Daniel Bratell, 2014-07-01 06:29:40]

Ah, yes, the comment. Updated it. Please take another look.

[iannucci, 2014-07-01 21:10:21]

lgtm

[Daniel Bratell, 2014-07-02 05:55:23]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-07-02 05:55:49]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/344013005/40001

[commit-bot: I haz the power, 2014-07-02 05:57:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 05:57:34]

Presubmit check for 344013005-40001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/git_cl_test.py (0.45s) failed
.ERROR:root:@0  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
FERROR:root:@0  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
F...ERROR: Gerrit commit-msg hook not available.
.ERROR:root:@34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
FERROR:root:@34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
FERROR:root:@34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
FERROR:root:@32  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
FERROR:root:@34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
FERROR:root:@34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
F.ERROR:root:@34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
FERROR:root:@34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
FERROR:root:@4  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
F.
======================================================================
FAIL: test_dcommit (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 522, in test_dcommit
    git_cl.main(['dcommit'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2054, in CMDdcommit
    if not settings.GetIsGitSvn():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 334, in GetIsGitSvn
    ['config', '--local', '--get-regexp', r'^svn-remote\..*\.url'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 106, in RunGitWithCode
    stderr=stderr)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @0  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)

======================================================================
FAIL: test_dcommit_bypass_hooks (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 529, in test_dcommit_bypass_hooks
    git_cl.main(['dcommit', '--bypass-hooks'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2054, in CMDdcommit
    if not settings.GetIsGitSvn():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 334, in GetIsGitSvn
    ['config', '--local', '--get-regexp', r'^svn-remote\..*\.url'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 106, in RunGitWithCode
    stderr=stderr)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @0  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)

======================================================================
FAIL: test_keep_find_copies (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 443, in test_keep_find_copies
    [])
  File "tests/git_cl_test.py", line 419, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1641, in RietveldUpload
    if settings.GetIsGitSvn():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 334, in GetIsGitSvn
    ['config', '--local', '--get-regexp', r'^svn-remote\..*\.url'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 106, in RunGitWithCode
    stderr=stderr)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)

======================================================================
FAIL: test_keep_similarity (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 435, in test_keep_similarity
    [])
  File "tests/git_cl_test.py", line 419, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1641, in RietveldUpload
    if settings.GetIsGitSvn():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 334, in GetIsGitSvn
    ['config', '--local', '--get-regexp', r'^svn-remote\..*\.url'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 106, in RunGitWithCode
    stderr=stderr)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)

======================================================================
FAIL: test_no_reviewer (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 427, in test_no_reviewer
    [])
  File "tests/git_cl_test.py", line 419, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1641, in RietveldUpload
    if settings.GetIsGitSvn():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 334, in GetIsGitSvn
    ['config', '--local', '--get-regexp', r'^svn-remote\..*\.url'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 106, in RunGitWithCode
    stderr=stderr)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @34  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)

======================================================================
FAIL: test_private (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 451, in test_private
    [])
  F…
(message too large)

[Daniel Bratell, 2014-07-02 07:02:41]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-07-02 07:03:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/344013005/60001

[commit-bot: I haz the power, 2014-07-02 07:06:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 07:06:26]

Presubmit check for 344013005-60001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/git_cl_test.py (0.68s) failed
......ERROR: Gerrit commit-msg hook not available.
.ERROR:root:@35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)
FERROR:root:@35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)
FERROR:root:@35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)
FERROR:root:@33  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)
FERROR:root:@35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)
FERROR:root:@35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)
F.ERROR:root:@35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)
FERROR:root:@35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)
FERROR:root:@4  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
F.
======================================================================
FAIL: test_keep_find_copies (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 443, in test_keep_find_copies
    [])
  File "tests/git_cl_test.py", line 419, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1649, in RietveldUpload
    if cl.GetRemoteUrl() and '/' in cl.GetUpstreamBranch():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 664, in GetRemoteUrl
    url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 93, in RunGit
    return RunCommand(['git'] + args, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 81, in RunCommand
    return subprocess2.check_output(args, shell=False, **kwargs)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)

======================================================================
FAIL: test_keep_similarity (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 435, in test_keep_similarity
    [])
  File "tests/git_cl_test.py", line 419, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1649, in RietveldUpload
    if cl.GetRemoteUrl() and '/' in cl.GetUpstreamBranch():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 664, in GetRemoteUrl
    url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 93, in RunGit
    return RunCommand(['git'] + args, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 81, in RunCommand
    return subprocess2.check_output(args, shell=False, **kwargs)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)

======================================================================
FAIL: test_no_reviewer (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 427, in test_no_reviewer
    [])
  File "tests/git_cl_test.py", line 419, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1649, in RietveldUpload
    if cl.GetRemoteUrl() and '/' in cl.GetUpstreamBranch():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 664, in GetRemoteUrl
    url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 93, in RunGit
    return RunCommand(['git'] + args, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 81, in RunCommand
    return subprocess2.check_output(args, shell=False, **kwargs)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @35  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)

======================================================================
FAIL: test_private (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 451, in test_private
    [])
  File "tests/git_cl_test.py", line 419, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1649, in RietveldUpload
    if cl.GetRemoteUrl() and '/' in cl.GetUpstreamBranch():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 664, in GetRemoteUrl
    url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 93, in RunGit
    return RunCommand(['git'] + args, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 81, in RunCommand
    return subprocess2.check_output(args, shell=False, **kwargs)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @33  Expected: (['git', 'rev-parse', '--show-cdup'],)   Actual:
(['git', 'config', 'remote.origin.url'],)

======================================================================
FAIL: test_reviewer_multiple (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 483, in test_reviewer_multiple
    ['--reviewers=another@example.com,reviewer@example.com'])
  File "tests/git_cl_test.py", line 419, in _run_reviewer_test
    git_cl.main(['upload'] + upload_args)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1649, in RietveldUpload
    if cl.GetRemoteUrl() and '/' in cl.GetUpstreamBranch():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 664, in GetRemoteUrl
    url = RunGit(['config', 'remote.%s.url' % remote], error_ok=True).strip()
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 93, in RunGit
    return RunCommand(['git'] + args, **kwargs)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 81, in RunCommand
    return subprocess2.check_output…
(message too large)

[Daniel Bratell, 2014-07-02 16:46:28]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-07-02 16:47:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/344013005/80001

[commit-bot: I haz the power, 2014-07-02 16:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 16:49:15]

Presubmit check for 344013005-80001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/git_cl_test.py (0.55s) failed
......ERROR: Gerrit commit-msg hook not available.
..........ERROR:root:@4  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
F.
======================================================================
FAIL: test_trybots_from_PRESUBMIT (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 799, in test_trybots_from_PRESUBMIT
    git_cl.main(['upload', '--bypass-hooks', '--auto-bots'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1641, in RietveldUpload
    if settings.GetIsGitSvn():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 334, in GetIsGitSvn
    ['config', '--local', '--get-regexp', r'^svn-remote\..*\.url'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 106, in RunGitWithCode
    stderr=stderr)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @4  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)

----------------------------------------------------------------------
Ran 18 tests in 0.099s

FAILED (failures=1)
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
Issue: 12345

R=john@chromium.org

Review URL: https://codereview.example.com/12345
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
Issue: 12345

R=john@chromium.org

Review URL: https://codereview.example.com/12345
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Note: Saving similarity of 70% in git config.
Using 70% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.


submit-from-new-dir.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/submit-from-new-dir.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
TESTING: git-cl dcommits ok
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: git-cl dcommits ok


submodule-merge-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/submodule-merge-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test remote git-svn-submodule repo...
Switched to branch 'master'
TESTING: dcommitted code
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: dcommitted code


post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: dcommitted code


basic.sh failed
Command /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/basic.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1827 --:--:-- --:--:-- --:--:--  1878
TESTING: git-cl dcommits ok
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/…
(message too large)

[Daniel Bratell, 2014-07-02 16:58:33]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-07-02 16:58:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/344013005/80001

[commit-bot: I haz the power, 2014-07-02 17:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 17:00:47]

Presubmit check for 344013005-80001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
tests/git_cl_test.py (0.52s) failed
......ERROR: Gerrit commit-msg hook not available.
..........ERROR:root:@4  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)
F.
======================================================================
FAIL: test_trybots_from_PRESUBMIT (__main__.TestGitCl)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/git_cl_test.py", line 799, in test_trybots_from_PRESUBMIT
    git_cl.main(['upload', '--bypass-hooks', '--auto-bots'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1792, in CMDupload
    ret = RietveldUpload(options, args, cl, change)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 1641, in RietveldUpload
    if settings.GetIsGitSvn():
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 334, in GetIsGitSvn
    ['config', '--local', '--get-regexp', r'^svn-remote\..*\.url'])
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/git_cl.py",
line 106, in RunGitWithCode
    stderr=stderr)
  File "tests/git_cl_test.py", line 112, in _mocked_call
    self.fail(msg)
AssertionError: @4  Expected: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\.'],)   Actual: (['git', 'config', '--local', '--get-regexp',
'^svn-remote\\..*\\.url'],)

----------------------------------------------------------------------
Ran 18 tests in 0.077s

FAILED (failures=1)
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
Issue: 12345

R=john@chromium.org

Review URL: https://codereview.example.com/12345
Using 50% similarity for rename/copy detection. Override with --similarity.
Description:
Issue: 12345

R=john@chromium.org

Review URL: https://codereview.example.com/12345
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Note: Saving similarity of 70% in git config.
Using 70% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.
Using 50% similarity for rename/copy detection. Override with --similarity.


submit-from-new-dir.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/submit-from-new-dir.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
TESTING: git-cl dcommits ok
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: git-cl dcommits ok


submodule-merge-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/submodule-merge-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test remote git-svn-submodule repo...
Switched to branch 'master'
TESTING: dcommitted code
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: dcommitted code


post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: dcommitted code


basic.sh failed
Command /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/basic.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1832 --:--:-- --:--:-- --:--:--  1878
TESTING: git-cl dcommits ok
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/…
(message too large)

[Daniel Bratell, 2014-07-02 17:03:35]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-07-02 17:03:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/344013005/100001

[commit-bot: I haz the power, 2014-07-02 17:05:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 17:05:40]

Presubmit check for 344013005-100001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (97 files) (28.57s) failed
************* Module
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/git_cl_test.py
C0301:778,0: Line too long (84/80)


submit-from-new-dir.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/submit-from-new-dir.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
TESTING: git-cl dcommits ok
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: git-cl dcommits ok


submodule-merge-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/submodule-merge-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test remote git-svn-submodule repo...
Switched to branch 'master'
TESTING: dcommitted code
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: dcommitted code


post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: dcommitted code


basic.sh failed
Command /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/basic.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   1912 --:--:-- --:--:-- --:--:--  1974
TESTING: git-cl dcommits ok
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: git-cl dcommits ok


Presubmit checks took 96.6s to calculate.

[Daniel Bratell, 2014-07-02 17:14:35]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-07-02 17:15:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/344013005/120001

[commit-bot: I haz the power, 2014-07-02 17:17:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-02 17:17:11]

Presubmit check for 344013005-120001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
submit-from-new-dir.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/submit-from-new-dir.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: upload succeeds
TESTING: git-cl dcommits ok
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: git-cl dcommits ok


submodule-merge-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/submodule-merge-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test remote git-svn-submodule repo...
Switched to branch 'master'
TESTING: dcommitted code
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: dcommitted code


post-dcommit-hook-test.sh failed
Command
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/post-dcommit-hook-test.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: dcommitted code
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: dcommitted code


basic.sh failed
Command /b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/basic.sh
returned non-zero exit status 1 in
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests
Setting up test SVN repo...
Setting up test git-svn repo...
TESTING: git-cl upload wants a server
TESTING: git-cl status has no issue
TESTING: upload succeeds (needs a server running on localhost)
TESTING: git-cl status now knows the issue
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--    
0
100    77    0     0  100    77      0   2499 --:--:-- --:--:-- --:--:--  2566
TESTING: git-cl dcommits ok
This doesn't appear to be an SVN repository.
If your project has a git mirror with an upstream SVN master, you probably need
to run 'git svn init', see your project's git mirror documentation.
If your project has a true writeable upstream repository, you probably want
to run 'git cl push' instead.
Choose wisely, if you get this wrong, your commit might appear to succeed but
will instead be silently ignored.
[Press enter to dcommit or ctrl-C to quit]Traceback (most recent call last):
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2662, in <module>
    sys.exit(main(sys.argv[1:]))
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2648, in main
    return dispatcher.execute(OptionParser(), argv)
  File "/b/infra_internal/commit_queue/workdir/tools/depot_tools/subcommand.py",
line 245, in execute
    return command(parser, args[1:])
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 2063, in CMDdcommit
    ask_for_data('[Press enter to dcommit or ctrl-C to quit]')
  File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/../git_cl.py",
line 123, in ask_for_data
    return raw_input(prompt)
EOFError: EOF when reading a line
FAILURE: git-cl dcommits ok


Presubmit checks took 121.2s to calculate.

[Daniel Bratell, 2014-07-04 12:07:46]

The problem was that tests used file:// urls to svn repos and those were no
longer accepted as svn repos by git cl.

iannucci, please take a new look!

[iannucci, 2014-07-04 17:08:43]

lgtm

https://codereview.chromium.org/344013005/diff/160001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/344013005/diff/160001/git_cl.py#newcode330
git_cl.py:330: # The presence of a svn-remote using the svn:// protocol
svn:// (or file://)

[Daniel Bratell, 2014-07-07 07:26:00]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-07-07 07:26:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bratell@opera.com/344013005/180001

[commit-bot: I haz the power, 2014-07-07 07:28:36]

Change committed as 281500

[andresp-chromium, 2014-07-07 09:09:54]

On 2014/07/07 07:28:36, I haz the power (commit-bot) wrote:
> Change committed as 281500

This broke my webrtc workflow. Where git svn remote url is:
 https://webrtc.googlecode.com/svn/trunk

I guess it broke the workflow for any other project that has the repository in
googlecode has it does not seems to support svn:// protocol.

[Daniel Bratell, 2014-07-07 09:17:45]

On 2014/07/07 09:09:54, andresp wrote:
> On 2014/07/07 07:28:36, I haz the power (commit-bot) wrote:
> > Change committed as 281500
> 
> This broke my webrtc workflow. Where git svn remote url is:
>  https://webrtc.googlecode.com/svn/trunk
> 
> I guess it broke the workflow for any other project that has the repository in
> googlecode has it does not seems to support svn:// protocol.

Argh.

I'll revert it.

[Daniel Bratell, 2014-07-07 09:18:19]

A revert of this CL has been created in
https://codereview.chromium.org/375553002/ by bratell@opera.com.

The reason for reverting is: Breaks WebRTC (and possibly other projects actually
using https:// for svn access)..

[iannucci, 2014-07-07 18:30:58]

On 2014/07/07 09:18:19, Daniel Bratell wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/375553002/ by mailto:bratell@opera.com.
> 
> The reason for reverting is: Breaks WebRTC (and possibly other projects
actually
> using https:// for svn access)..

:(

[Daniel Bratell, 2014-07-08 15:37:33]

On 2014/07/07 18:30:58, iannucci wrote:
> On 2014/07/07 09:18:19, Daniel Bratell wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/375553002/ by mailto:bratell@opera.com.
> > 
> > The reason for reverting is: Breaks WebRTC (and possibly other projects
> actually
> > using https:// for svn access)..
> 
> :(

Not been able to locate a better heuristic. How bad would it be to hardcode a
few repo names (Blink and Chromium)?

[Daniel Bratell, 2014-09-01 12:38:53]

On 2014/07/08 15:37:33, Daniel Bratell wrote:
> On 2014/07/07 18:30:58, iannucci wrote:
> > On 2014/07/07 09:18:19, Daniel Bratell wrote:
> > > A revert of this CL has been created in
> > > https://codereview.chromium.org/375553002/ by mailto:bratell@opera.com.
> > > 
> > > The reason for reverting is: Breaks WebRTC (and possibly other projects
> > actually
> > > using https:// for svn access)..
> > 
> > :(
> 
> Not been able to locate a better heuristic. How bad would it be to hardcode a
> few repo names (Blink and Chromium)?

Closing since mixed svn/git support is not very interesting anymore. At least
not to me.