Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: tests/git_cl_test.py

Issue 344013005: Allow git cl also in repos with read-only git-svn. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Git cl: Modified comment as well Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/git_cl_test.py
diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py
index f7f57b4cf9e07d363a5f52022fb6ab77136ae4e1..3af5d3062aaf9196f4b919742ebf24f9bc14e5cc 100755
--- a/tests/git_cl_test.py
+++ b/tests/git_cl_test.py
@@ -207,8 +207,8 @@ class TestGitCl(TestCase):
] + cc_call + private_call + [
((['git', 'config', 'branch.master.base-url'],), ''),
((['git',
- 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
- (('', None), 0)),
+ 'config', '--local', '--get-regexp', '^svn-remote\\..*\\.url'],),
+ (('svn-remote.mybranch.url svn://svn.chromium.org/chrome', None), 0)),
((['git', 'rev-parse', '--show-cdup'],), ''),
((['git', 'svn', 'info'],), ''),
((['git', 'config', 'rietveld.project'],), ''),
@@ -253,7 +253,7 @@ class TestGitCl(TestCase):
def _dcommit_calls_1(cls):
return [
((['git',
- 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
+ 'config', '--local', '--get-regexp', '^svn-remote\\..*\\.url'],),
((('svn-remote.svn.url svn://svn.chromium.org/chrome\n'
'svn-remote.svn.fetch trunk/src:refs/remotes/origin/master'),
None),
@@ -775,7 +775,8 @@ class TestGitCl(TestCase):
''),
((['git', 'config', 'rietveld.private',],),
''),
- ((['git', 'config', '--local', '--get-regexp', '^svn-remote\\.'],),
+ ((['git', 'config', '--local', '--get-regexp',
+ '^svn-remote\\..*\\.url',],),
''),
((['git', 'config', 'rietveld.project',],),
''),
« no previous file with comments | « git_cl.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698