Allow git cl also in repos with read-only git-svn.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld."""
 
 import datetime
@@ skipping 309 matching lines @@
     return RunGit(['rev-parse', '--show-cdup']).strip()
 
   def GetRoot(self):
     if self.root is None:
       self.root = os.path.abspath(self.GetRelativeRoot())
     return self.root
 
   def GetIsGitSvn(self):
     """Return true if this repo looks like it's using git-svn."""
     if self.is_git_svn is None:
       # If you have any "svn-remote.*" config keys, we think you're using svn.

[iannucci, 2014/06/30 18:08:11]

can you update the comment too? Something like:

If you have any svn-remote with a url using the svn:// protocol, we think you're
using svn. We assume that http* protocols indicate a read-only svn remote.


ick... I felt bad writing that :(

-      self.is_git_svn = RunGitWithCode(
-          ['config', '--local', '--get-regexp', r'^svn-remote\.'])[0] == 0
+      code, result = RunGitWithCode(
+          ['config', '--local', '--get-regexp', r'^svn-remote\..*\.url'])
+      self.is_git_svn = (code == 0 and "svn://" in result)
     return self.is_git_svn
 
   def GetSVNBranch(self):
     if self.svn_branch is None:
       if not self.GetIsGitSvn():
         DieWithError('Repo doesn\'t appear to be a git-svn repo.')
 
       # Try to figure out which remote branch we're based on.
       # Strategy:
       # 1) iterate through our branch history and find the svn URL.
@@ skipping 2289 matching lines @@
         ('AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
           'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)))
 
 
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   sys.exit(main(sys.argv[1:]))