Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 343593006: Revert 276939 "Decouple IPC::MessageFilter from IPC::Channel" (Closed)

Created:
6 years, 6 months ago by amineer_google
Modified:
6 years, 6 months ago
Reviewers:
Hajime Morrita
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, jdduke+watch_chromium.org, serviceworker-reviews, jam, mcasas+watch_chromium.org, nhiroki, feature-media-reviews_chromium.org, dsinclair+watch_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, piman+watch_chromium.org, kinuko+serviceworker, wjia+watch_chromium.org, alecflett+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert 276939 "Decouple IPC::MessageFilter from IPC::Channel" Reverting on branch only to get to an underlying change as discussed > Decouple IPC::MessageFilter from IPC::Channel > > This change gets rid of Channel dependency from MessageFilter > so that it depends only on IPC::Sender. > > TEST=none > BUG=377980 > R=jam@chromium.org, darin@chromium.org > > Review URL: https://codereview.chromium.org/324143002 TBR=morrita@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -192 lines) Patch
M chrome/renderer/media/cast_ipc_dispatcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/media/cast_ipc_dispatcher.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M components/nacl/renderer/pnacl_translation_resource_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/nacl/renderer/pnacl_translation_resource_host.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M components/tracing/child_trace_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/tracing/child_trace_message_filter.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/dom_storage/dom_storage_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/p2p/socket_dispatcher_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/child_histogram_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/child_histogram_message_filter.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/child/child_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/font_cache_dispatcher_win.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/common/font_cache_dispatcher_win.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M content/plugin/plugin_channel.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/browser_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/browser_message_filter.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/input/input_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/input_event_filter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/audio_input_message_filter.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M content/renderer/media/audio_message_filter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/audio_message_filter.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/midi_message_filter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/midi_message_filter.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/video_capture_message_filter.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/p2p/socket_dispatcher.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M content/renderer/pepper/pepper_hung_plugin_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_hung_plugin_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/ipc_sync_message_filter.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M ipc/message_filter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ipc/message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/plugin_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/proxy/plugin_message_filter.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M win8/viewer/metro_viewer_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
amineer_google
6 years, 6 months ago (2014-06-18 20:53:10 UTC) #1
amineer_google
Committed patchset #1 manually as r278169.
6 years, 6 months ago (2014-06-18 20:55:30 UTC) #2
Hajime Morrita
6 years, 6 months ago (2014-06-18 21:02:25 UTC) #3
Message was sent while issue was closed. 
lgtm.

Powered by Google App Engine
This is Rietveld 408576698