Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4942)

Unified Diff: chrome/renderer/media/webrtc_logging_message_filter.cc

Issue 343593006: Revert 276939 "Decouple IPC::MessageFilter from IPC::Channel" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2057/src/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/media/webrtc_logging_message_filter.cc
===================================================================
--- chrome/renderer/media/webrtc_logging_message_filter.cc (revision 278168)
+++ chrome/renderer/media/webrtc_logging_message_filter.cc (working copy)
@@ -14,7 +14,7 @@
const scoped_refptr<base::MessageLoopProxy>& io_message_loop)
: io_message_loop_(io_message_loop),
log_message_delegate_(NULL),
- sender_(NULL) {
+ channel_(NULL) {
// May be null in a browsertest using MockRenderThread.
if (io_message_loop_) {
io_message_loop_->PostTask(
@@ -39,20 +39,20 @@
return handled;
}
-void WebRtcLoggingMessageFilter::OnFilterAdded(IPC::Sender* sender) {
+void WebRtcLoggingMessageFilter::OnFilterAdded(IPC::Channel* channel) {
DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- sender_ = sender;
+ channel_ = channel;
}
void WebRtcLoggingMessageFilter::OnFilterRemoved() {
DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- sender_ = NULL;
+ channel_ = NULL;
log_message_delegate_->OnFilterRemoved();
}
void WebRtcLoggingMessageFilter::OnChannelClosing() {
DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- sender_ = NULL;
+ channel_ = NULL;
log_message_delegate_->OnFilterRemoved();
}
@@ -85,10 +85,10 @@
void WebRtcLoggingMessageFilter::Send(IPC::Message* message) {
DCHECK(!io_message_loop_ || io_message_loop_->BelongsToCurrentThread());
- if (!sender_) {
- DLOG(ERROR) << "IPC sender not available.";
+ if (!channel_) {
+ DLOG(ERROR) << "IPC channel not available.";
delete message;
} else {
- sender_->Send(message);
+ channel_->Send(message);
}
}
« no previous file with comments | « chrome/renderer/media/webrtc_logging_message_filter.h ('k') | components/nacl/renderer/pnacl_translation_resource_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698