Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2432)

Unified Diff: content/public/browser/browser_message_filter.cc

Issue 343593006: Revert 276939 "Decouple IPC::MessageFilter from IPC::Channel" (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2057/src/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/browser_message_filter.h ('k') | content/renderer/input/input_event_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/browser_message_filter.cc
===================================================================
--- content/public/browser/browser_message_filter.cc (revision 278168)
+++ content/public/browser/browser_message_filter.cc (working copy)
@@ -30,9 +30,9 @@
virtual ~Internal() {}
// IPC::MessageFilter implementation:
- virtual void OnFilterAdded(IPC::Sender* sender) OVERRIDE {
- filter_->sender_ = sender;
- filter_->OnFilterAdded(sender);
+ virtual void OnFilterAdded(IPC::Channel* channel) OVERRIDE {
+ filter_->channel_ = channel;
+ filter_->OnFilterAdded(channel);
}
virtual void OnFilterRemoved() OVERRIDE {
@@ -40,7 +40,7 @@
}
virtual void OnChannelClosing() OVERRIDE {
- filter_->sender_ = NULL;
+ filter_->channel_ = NULL;
filter_->OnChannelClosing();
}
@@ -101,7 +101,7 @@
BrowserMessageFilter::BrowserMessageFilter(uint32 message_class_to_filter)
: internal_(NULL),
- sender_(NULL),
+ channel_(NULL),
#if defined(OS_WIN)
peer_handle_(base::kNullProcessHandle),
#endif
@@ -112,7 +112,7 @@
const uint32* message_classes_to_filter,
size_t num_message_classes_to_filter)
: internal_(NULL),
- sender_(NULL),
+ channel_(NULL),
#if defined(OS_WIN)
peer_handle_(base::kNullProcessHandle),
#endif
@@ -161,8 +161,8 @@
return true;
}
- if (sender_)
- return sender_->Send(message);
+ if (channel_)
+ return channel_->Send(message);
delete message;
return false;
« no previous file with comments | « content/public/browser/browser_message_filter.h ('k') | content/renderer/input/input_event_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698