Source/core/svg/SVGStopElement.cpp - Issue 343443003: Remove SVGElement::rendererIsNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGStopElement.cpp

Issue 343443003: Remove SVGElement::rendererIsNeeded (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove accidently squashed patch Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGStopElement.cpp

diff --git a/Source/core/svg/SVGStopElement.cpp b/Source/core/svg/SVGStopElement.cpp

index 158ba3f1024def854900f54bb88eca5dfa4b8194..5883e4882bd50ed68f54327d430e8dd6ef9e24b9 100644

--- a/Source/core/svg/SVGStopElement.cpp

+++ b/Source/core/svg/SVGStopElement.cpp

@@ -90,7 +90,7 @@ RenderObject* SVGStopElement::createRenderer(RenderStyle*)

bool SVGStopElement::rendererIsNeeded(const RenderStyle&)

{

- return true;

+ return parentOrShadowHostElement() && parentOrShadowHostElement()->isSVGElement() && isValid();

pdr. 2014/06/19 21:33:48 Do we need the same in SVGMarkerElement? Do we ne

}

Color SVGStopElement::stopColorIncludingOpacity() const