Source/core/svg/SVGGElement.cpp - Issue 343443003: Remove SVGElement::rendererIsNeeded

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGGElement.cpp

Issue 343443003: Remove SVGElement::rendererIsNeeded (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Remove accidently squashed patch Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGGElement.cpp

diff --git a/Source/core/svg/SVGGElement.cpp b/Source/core/svg/SVGGElement.cpp

index b9cc50355f2ca895fc93f5e49c5ef77468f1c942..eb25fabb054ed0802d76e574ff9c75cbc97d9fdc 100644

--- a/Source/core/svg/SVGGElement.cpp

+++ b/Source/core/svg/SVGGElement.cpp

@@ -82,7 +82,7 @@ bool SVGGElement::rendererIsNeeded(const RenderStyle&)

{

// Unlike SVGElement::rendererIsNeeded(), we still create renderers, even if

// display is set to 'none' - which is special to SVG <g> container elements.

- return parentOrShadowHostElement() && parentOrShadowHostElement()->isSVGElement();

+ return (parentOrShadowHostElement() && parentOrShadowHostElement()->isSVGElement()) && isValid();

pdr. 2014/06/19 21:33:48 No need for parenthesis, these are all &&'s

}