Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1787)

Unified Diff: Source/core/svg/SVGTSpanElement.cpp

Issue 343443003: Remove SVGElement::rendererIsNeeded (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Remove accidently squashed patch Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/SVGTSpanElement.cpp
diff --git a/Source/core/svg/SVGTSpanElement.cpp b/Source/core/svg/SVGTSpanElement.cpp
index 080ca5a66f7cc85ef4e8de51ea9f38189342e24b..23b8b73fcebb721f51f7d989d53d2ffa873f3ef6 100644
--- a/Source/core/svg/SVGTSpanElement.cpp
+++ b/Source/core/svg/SVGTSpanElement.cpp
@@ -42,15 +42,16 @@ RenderObject* SVGTSpanElement::createRenderer(RenderStyle*)
bool SVGTSpanElement::rendererIsNeeded(const RenderStyle& style)
{
- if (parentNode()
- && (isSVGAElement(*parentNode())
+ if (Node* parent = parentNode()) {
+ if ((isSVGAElement(*parent)
#if ENABLE(SVG_FONTS)
- || isSVGAltGlyphElement(*parentNode())
+ || isSVGAltGlyphElement(*parent)
#endif
- || isSVGTextElement(*parentNode())
- || isSVGTextPathElement(*parentNode())
- || isSVGTSpanElement(*parentNode())))
- return Element::rendererIsNeeded(style);
+ || isSVGTextElement(*parent)
+ || isSVGTextPathElement(*parent)
+ || isSVGTSpanElement(*parent)))
+ return isValid() && Element::rendererIsNeeded(style);
pdr. 2014/06/19 21:33:48 Can you call SVGElement::rendererIsNeeded here? Th
+ }
return false;
}

Powered by Google App Engine
This is Rietveld 408576698