Issue 343283002: No need to include ../tools/flags in include_dirs when depending on flags target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 343283002: No need to include ../tools/flags in include_dirs when depending on flags target. (Closed)

Created:
6 years, 6 months ago by tfarina

Modified:
6 years, 6 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

No need to include ../tools/flags in include_dirs when depending on flags target. "flags" target does it by direct_dependent_settings which exports the include_dirs to targets that depend on it. Along the way fixed the indentation of experimental.gyp and v8.gyp. BUG=None TEST=make all R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/1c4d5784f9957143e86a7455e64ea6ac9661bb9e

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+116 lines, -138 lines)			Patch
M	gyp/everything.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/experimental.gyp	View		1 chunk	+44 lines, -57 lines	0 comments	Download
M	gyp/flags.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	gyp/pathops_unittest.gyp	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	gyp/tools.gyp	View	1 2	3 chunks	+1 line, -4 lines	0 comments	Download
M	gyp/v8.gyp	View		1 chunk	+67 lines, -72 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/343283002/40001

6 years, 6 months ago (2014-06-22 23:02:49 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-22 23:13:04 UTC) #5

Message was sent while issue was closed.

Change committed as 1c4d5784f9957143e86a7455e64ea6ac9661bb9e

Expand Messages | Collapse Messages