gyp/tools.gyp - Issue 343283002: No need to include ../tools/flags in include_dirs when depending on flags target.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/tools.gyp

Issue 343283002: No need to include ../tools/flags in include_dirs when depending on flags target. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gyp/tools.gyp

diff --git a/gyp/tools.gyp b/gyp/tools.gyp

index 6913cc1c67d3f4928c35f8a4633c59d35f1d30b1..256852ddff5dca12a955576286c1dd2cab1f02e7 100644

--- a/gyp/tools.gyp

+++ b/gyp/tools.gyp

@@ -159,13 +159,12 @@

'../tools/skpdiff/SkImageDiffer.cpp',

'../tools/skpdiff/SkPMetric.cpp',

'../tools/skpdiff/skpdiff_util.cpp',

- '../tools/flags/SkCommandLineFlags.cpp',

'include_dirs': [

- '../tools/flags',

'../src/core/', # needed for SkTLList.h

'dependencies': [

+ 'flags.gyp:flags',

'skia_lib.gyp:skia_lib',

'cflags': [

@@ -282,7 +281,6 @@

'../tools/skpinfo.cpp',

'include_dirs': [

- '../tools/flags',

'../src/core/',

'dependencies': [

@@ -301,7 +299,6 @@

'../src/core/',

'../src/images',

'../src/lazy',

- '../tools/flags',

'dependencies': [

'flags.gyp:flags',

« no previous file with comments | « gyp/pathops_unittest.gyp ('k') | gyp/v8.gyp » ('j') | no next file with comments »