gyp/flags.gyp - Issue 343283002: No need to include ../tools/flags in include_dirs when depending on flags target.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gyp/flags.gyp

Issue 343283002: No need to include ../tools/flags in include_dirs when depending on flags target. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # GYP file to build flag parser	1 # GYP file to build flag parser

2 #	2 #

3 {	3 {

4 'targets': [	4 'targets': [

5 {	5 {

6 'target_name': 'flags',	6 'target_name': 'flags',

7 'type': 'static_library',	7 'type': 'static_library',

8 'sources': [	8 'sources': [

	9 '../tools/flags/SkCommandLineFlags.cpp',

9 '../tools/flags/SkCommandLineFlags.h',	10 '../tools/flags/SkCommandLineFlags.h',

10 '../tools/flags/SkCommandLineFlags.cpp',

11 ],	11 ],

12 'dependencies': [	12 'dependencies': [

13 'skia_lib.gyp:skia_lib',	13 'skia_lib.gyp:skia_lib',

14 ],	14 ],

15 'direct_dependent_settings': {	15 'direct_dependent_settings': {

16 'include_dirs': [	16 'include_dirs': [

17 '../tools/flags',	17 '../tools/flags',

18 ],	18 ],

19 }	19 }

20 },	20 },

21 ],	21 ],

22 }	22 }

OLD	NEW

« no previous file with comments | « gyp/experimental.gyp ('k') | gyp/pathops_unittest.gyp » ('j') | no next file with comments »