Issue 343233002: Make chrome/common compile in GN

Issue 343233002: Make chrome/common compile in GN (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
jamesr

CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, haitaol+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, albertb+watch_chromium.org, kalyank, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org, ben+ash_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Make chrome/common compile in GN Adds extensions common API target and extensions templates. Adds a number of new targets: widevine, flash, sync proto, metrics proto, device serial. Minor enhancements to protobuf and mojo templates. TBR=jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278828

Patch Set 1 #

Total comments: 7

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+656 lines, -148 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	build/json_schema.gni	View	1 chunk	+140 lines, -0 lines	1 comment	Download
M	build/json_schema_bundle_compile.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	build/json_schema_compile.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/BUILD.gn	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	chrome/common/extensions/api/BUILD.gn	View	1 chunk	+73 lines, -0 lines	3 comments	Download
M	chrome/common/extensions/api/api.gyp	View	3 chunks	+176 lines, -134 lines	1 comment	Download
M	components/BUILD.gn	View	1 chunk	+1 line, -1 line	2 comments	Download
M	components/metrics.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	components/metrics/proto/BUILD.gn	View	1 chunk	+20 lines, -0 lines	0 comments	Download
A	device/serial/BUILD.gn	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	device/serial/serial.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/public/tools/bindings/mojom.gni	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	sync/BUILD.gn	View	1 chunk	+13 lines, -0 lines	0 comments	Download
A	sync/protocol/BUILD.gn	View	1 chunk	+56 lines, -0 lines	0 comments	Download
M	sync/sync.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/sync_proto.gypi	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	third_party/adobe/flash/BUILD.gn	View	1 chunk	+65 lines, -0 lines	0 comments	Download
M	third_party/adobe/flash/flash_player.gyp	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	third_party/protobuf/proto_library.gni	View	2 chunks	+39 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

Committed patchset #1 manually as r278828 (presubmit successful).

6 years, 6 months ago (2014-06-20 21:40:06 UTC) #2

jamesr

lgtm https://codereview.chromium.org/343233002/diff/1/build/json_schema.gni File build/json_schema.gni (right): https://codereview.chromium.org/343233002/diff/1/build/json_schema.gni#newcode10 build/json_schema.gni:10: # it should possibly be moved there. that ...

6 years, 6 months ago (2014-06-20 21:45:08 UTC) #3

brettw

6 years, 6 months ago (2014-06-21 00:26:30 UTC) #4

Message was sent while issue was closed.

Fixes on https://codereview.chromium.org/333173004

https://codereview.chromium.org/343233002/diff/1/components/BUILD.gn
File components/BUILD.gn (right):

https://codereview.chromium.org/343233002/diff/1/components/BUILD.gn#newcode7
components/BUILD.gn:7: group("all_components") {
There's an implicit "all" target. Naming something else "all" causes collisions.
Probably the writer for the phony rules should know about the implicit "all" one
and skip collisions, but it doesn't now.

Expand Messages | Collapse Messages