components/BUILD.gn - Issue 343233002: Make chrome/common compile in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/BUILD.gn

Issue 343233002: Make chrome/common compile in GN (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/BUILD.gn

diff --git a/components/BUILD.gn b/components/BUILD.gn

index 00543411b0919b78cfc22db5973ad8cf7008d4d3..358fbf1bf03538a8bc76b462594515d865ff8643 100644

--- a/components/BUILD.gn

+++ b/components/BUILD.gn

@@ -4,7 +4,7 @@

# Collection of all components. You wouldn't link to this, but this is rather

# to reference the files so they can be compiled by the build system.

-group("all") {

+group("all_components") {

jamesr 2014/06/20 21:45:08 //components:all_components is repetative - what's

brettw 2014/06/21 00:26:30 There's an implicit "all" target. Naming something

visibility = "//:*" # Only for the root targets to bring in.

deps = [