Make chrome/common compile in GN

components/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Collection of all components. You wouldn't link to this, but this is rather
 # to reference the files so they can be compiled by the build system.
-group("all") {
+group("all_components") {

[jamesr, 2014/06/20 21:45:08]

//components:all_components is repetative - what's wrong with //components:all ?
consistency with gyp?

[brettw, 2014/06/21 00:26:30]

There's an implicit "all" target. Naming something else "all" causes collisions.
Probably the writer for the phony rules should know about the implicit "all" one
and skip collisions, but it doesn't now.

   visibility = "//:*"  # Only for the root targets to bring in.
 
   deps = [
     "//components/cloud_devices/common",
     "//components/favicon_base",
     "//components/json_schema",
     "//components/language_usage_metrics",
     "//components/metrics",
     "//components/navigation_metrics",
     "//components/onc",
@@ skipping 19 matching lines @@
     deps -= [
       "//components/cloud_devices/common",  # Should work, needs checking.
       "//components/json_schema",  # Should work, needs checking.
       "//components/keyed_service/content",  # Blocked on content.
       "//components/user_prefs",  # Blocked on content.
       "//components/visitedlink/browser",  # Blocked on content.
       "//components/visitedlink/common",  # Blocked on content.
     ]
   }
 }