Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 342483007: Removed ManagedMemoryStats. (Closed)

Created:
6 years, 6 months ago by vmpstr
Modified:
6 years, 6 months ago
CC:
chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, abarth-chromium, ben+mojo_chromium.org, danakj+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Removed ManagedMemoryStats. As of r277056, the gpu memory manager is no longer using managed memory stats produced. This patch removes the managed memory stats calculation from the tile manager. As well, this patch removes ununsed gpu managed memory stats plumbing. BUG=377065 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278294

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -399 lines) Patch
M cc/output/delegating_renderer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/output/delegating_renderer.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M cc/output/gl_renderer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M cc/output/renderer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/output/software_renderer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M cc/resources/tile_manager.h View 3 chunks +0 lines, -9 lines 0 comments Download
M cc/resources/tile_manager.cc View 5 chunks +0 lines, -48 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M cc/test/fake_layer_tree_host_impl_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/test_context_support.h View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/test/test_context_support.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 3 chunks +0 lines, -9 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 5 chunks +0 lines, -47 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M cc/trees/thread_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/thread_proxy.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 1 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_manager_client.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 1 3 chunks +0 lines, -13 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 2 chunks +0 lines, -12 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/context_support.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M gpu/command_buffer/client/gpu_control.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gpu_memory_allocation.h View 1 1 chunk +0 lines, -42 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
vmpstr
Please take a look. Let me know if I missed something.
6 years, 6 months ago (2014-06-18 17:25:01 UTC) #1
ccameron
lgtm Thanks for pulling this out!
6 years, 6 months ago (2014-06-18 17:29:35 UTC) #2
reveman
lgtm
6 years, 6 months ago (2014-06-18 17:50:06 UTC) #3
Ken Russell (switch to Gerrit)
lgtm
6 years, 6 months ago (2014-06-18 20:54:13 UTC) #4
piman
lgtm
6 years, 6 months ago (2014-06-18 21:53:43 UTC) #5
piman
+jschuh for gpu_messages.h (removing one IPC).
6 years, 6 months ago (2014-06-18 21:54:40 UTC) #6
jschuh
ipc security rubberstamp lgtm
6 years, 6 months ago (2014-06-18 21:57:09 UTC) #7
vmpstr
+jamesr for mojo/
6 years, 6 months ago (2014-06-18 22:03:46 UTC) #8
jamesr
lgtm
6 years, 6 months ago (2014-06-18 22:08:14 UTC) #9
vmpstr
The CQ bit was checked by vmpstr@chromium.org
6 years, 6 months ago (2014-06-18 22:57:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vmpstr@chromium.org/342483007/20001
6 years, 6 months ago (2014-06-18 23:00:47 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 07:01:47 UTC) #12
Message was sent while issue was closed. 
Change committed as 278294

Powered by Google App Engine
This is Rietveld 408576698