Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 342253002: Revert 278338 "Smart Revert 276260 "Win Video Capture: Add suppo..." (Closed)

Created:
6 years, 6 months ago by amineer_google
Modified:
6 years, 6 months ago
Reviewers:
mcasas
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 278338 "Smart Revert 276260 "Win Video Capture: Add suppo..." Reverting from trunk at author's request to address crash. > Smart Revert 276260 "Win Video Capture: Add support for HDYC pixel for..." > > "Smart" because it needed some rebasing. > > > Win Video Capture: Add support for HDYC pixel format. > > > > This pixel format is a synonym of YUYV and is needed > > for at least the DeckLink video capture card. > > This format is not specified in Windows headers > > probably because this is just a synonym of other > > pixel formats, IOW they are all the same except for > > the first word, which is the name read in hex > > backwards: > > 30323449 --> 0x30 0x32 0x34 0x49 -> 024I > > 43594448 --> 0x43 0x59 0x44 0x48 -> CYDH > > > > and then all the YUV (422 and 420 alike) use the same > > trailing sequence > > ... 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}} > > > > HDYC: http://www.fourcc.org/yuv.php#HDYC > > > > BUG=380939 > > > > Review URL: https://codereview.chromium.org/317073010 > > NOTRY=true > > TBR=mcasas@chromium.org > > Review URL: https://codereview.chromium.org/338853009 TBR=mcasas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278553

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M trunk/src/media/video/capture/win/sink_filter_win.h View 1 chunk +6 lines, -2 lines 0 comments Download
M trunk/src/media/video/capture/win/sink_filter_win.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M trunk/src/media/video/capture/win/video_capture_device_win.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
amineer_google
6 years, 6 months ago (2014-06-20 00:39:33 UTC) #1
amineer_google
6 years, 6 months ago (2014-06-20 00:39:39 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r278553.

Powered by Google App Engine
This is Rietveld 408576698