Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 338853009: Smart Revert 276260 Win Video Capture: Add support for HDYC pixel for... (Closed)

Created:
6 years, 6 months ago by mcasas
Modified:
6 years, 6 months ago
Reviewers:
mcasas
CC:
chromium-reviews, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Smart Revert 276260 "Win Video Capture: Add support for HDYC pixel for..." "Smart" because it needed some rebasing. > Win Video Capture: Add support for HDYC pixel format. > > This pixel format is a synonym of YUYV and is needed > for at least the DeckLink video capture card. > This format is not specified in Windows headers > probably because this is just a synonym of other > pixel formats, IOW they are all the same except for > the first word, which is the name read in hex > backwards: > 30323449 --> 0x30 0x32 0x34 0x49 -> 024I > 43594448 --> 0x43 0x59 0x44 0x48 -> CYDH > > and then all the YUV (422 and 420 alike) use the same > trailing sequence > ... 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}} > > HDYC: http://www.fourcc.org/yuv.php#HDYC > > BUG=380939 > > Review URL: https://codereview.chromium.org/317073010 NOTRY=true TBR=mcasas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278338

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M media/video/capture/win/sink_filter_win.h View 1 chunk +2 lines, -6 lines 0 comments Download
M media/video/capture/win/sink_filter_win.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 6 months ago (2014-06-19 11:01:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/338853009/1
6 years, 6 months ago (2014-06-19 11:03:31 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 12:00:10 UTC) #3
Message was sent while issue was closed.
Change committed as 278338

Powered by Google App Engine
This is Rietveld 408576698