Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 317073010: Win Video Capture: Add support for HDYC pixel format. (Closed)

Created:
6 years, 6 months ago by mcasas
Modified:
6 years, 6 months ago
CC:
chromium-reviews, fischman+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org
Visibility:
Public.

Description

Win Video Capture: Add support for HDYC pixel format. This pixel format is a synonym of YUYV and is needed for at least the DeckLink video capture card. This format is not specified in Windows headers probably because this is just a synonym of other pixel formats, IOW they are all the same except for the first word, which is the name read in hex backwards: 30323449 --> 0x30 0x32 0x34 0x49 -> 024I 43594448 --> 0x43 0x59 0x44 0x48 -> CYDH and then all the YUV (422 and 420 alike) use the same trailing sequence ... 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xaa, 0x00, 0x38, 0x9b, 0x71}} HDYC: http://www.fourcc.org/yuv.php#HDYC BUG=380939 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276260

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : tommi@s nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M media/video/capture/win/sink_filter_win.h View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M media/video/capture/win/sink_filter_win.cc View 1 2 1 chunk +9 lines, -3 lines 0 comments Download
M media/video/capture/win/video_capture_device_factory_win.cc View 1 2 1 chunk +13 lines, -4 lines 0 comments Download
M media/video/capture/win/video_capture_device_win.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mcasas
niklase@ PTAL. Note that you mentioned HDYC --> YUY2 but according to [1] is actually ...
6 years, 6 months ago (2014-06-05 23:50:10 UTC) #1
Niklas Enbom
ok, will test first On 2014/06/05 23:50:10, mcasas wrote: > niklase@ PTAL. > > Note ...
6 years, 6 months ago (2014-06-06 16:52:27 UTC) #2
Niklas Enbom
Doesn't solve all the problems, but a step in the right direction. lgtm On 2014/06/06 ...
6 years, 6 months ago (2014-06-09 20:32:32 UTC) #3
mcasas
tommi@ PTAL.
6 years, 6 months ago (2014-06-09 22:08:13 UTC) #4
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/317073010/diff/20001/media/video/capture/win/sink_filter_win.cc File media/video/capture/win/sink_filter_win.cc (right): https://codereview.chromium.org/317073010/diff/20001/media/video/capture/win/sink_filter_win.cc#newcode15 media/video/capture/win/sink_filter_win.cc:15: 0x30323449, 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xAA, 0x00, ...
6 years, 6 months ago (2014-06-10 07:38:45 UTC) #5
mcasas
The CQ bit was checked by mcasas@chromium.org
6 years, 6 months ago (2014-06-10 18:46:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mcasas@chromium.org/317073010/40001
6 years, 6 months ago (2014-06-10 18:49:25 UTC) #7
mcasas
https://codereview.chromium.org/317073010/diff/20001/media/video/capture/win/sink_filter_win.cc File media/video/capture/win/sink_filter_win.cc (right): https://codereview.chromium.org/317073010/diff/20001/media/video/capture/win/sink_filter_win.cc#newcode15 media/video/capture/win/sink_filter_win.cc:15: 0x30323449, 0x0000, 0x0010, {0x80, 0x00, 0x00, 0xAA, 0x00, 0x38, ...
6 years, 6 months ago (2014-06-10 18:56:53 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 04:52:43 UTC) #9
Message was sent while issue was closed.
Change committed as 276260

Powered by Google App Engine
This is Rietveld 408576698