Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 342233002: Revert 278483 "[Downloads] Retry renames after transient failures." (Closed)

Created:
6 years, 6 months ago by yzshen1
Modified:
6 years, 6 months ago
Reviewers:
asanka
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 278483 "[Downloads] Retry renames after transient failures." > [Downloads] Retry renames after transient failures. > > If the cause of a rename failure is suspected of being transient > (sharing violations, suspected race conditions in the file system), then > retry the rename with an exponential backoff. > > BUG=368455 > > Review URL: https://codereview.chromium.org/319603003 TBR=asanka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278537

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -562 lines) Patch
M trunk/src/content/browser/download/base_file.h View 2 chunks +2 lines, -12 lines 0 comments Download
M trunk/src/content/browser/download/base_file.cc View 2 chunks +9 lines, -11 lines 0 comments Download
M trunk/src/content/browser/download/base_file_posix.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M trunk/src/content/browser/download/base_file_unittest.cc View 1 chunk +0 lines, -52 lines 0 comments Download
M trunk/src/content/browser/download/base_file_win.cc View 4 chunks +5 lines, -31 lines 0 comments Download
M trunk/src/content/browser/download/download_file_impl.h View 1 chunk +0 lines, -29 lines 0 comments Download
M trunk/src/content/browser/download/download_file_impl.cc View 3 chunks +43 lines, -86 lines 0 comments Download
M trunk/src/content/browser/download/download_file_unittest.cc View 16 chunks +74 lines, -260 lines 0 comments Download
M trunk/src/content/browser/download/download_interrupt_reasons_impl.h View 2 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/content/browser/download/download_interrupt_reasons_impl.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M trunk/src/content/browser/download/download_stats.h View 1 chunk +0 lines, -5 lines 0 comments Download
M trunk/src/content/browser/download/download_stats.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M trunk/src/content/public/browser/download_interrupt_reason_values.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/tools/metrics/histograms/histograms.xml View 3 chunks +1 line, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
yzshen1
6 years, 6 months ago (2014-06-20 00:03:21 UTC) #1
yzshen1
Committed patchset #1 manually as r278537 (tree was closed).
6 years, 6 months ago (2014-06-20 00:03:45 UTC) #2
yzshen1
6 years, 6 months ago (2014-06-20 00:07:40 UTC) #3 
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%283%29/builds...

(view as text)
BaseFileTest.RenameWithError (run #1):
[ RUN      ] BaseFileTest.RenameWithError
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(473):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] BaseFileTest.RenameWithError (282 ms)

BaseFileTest.RenameWithError (run #2):
[ RUN      ] BaseFileTest.RenameWithError
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(473):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] BaseFileTest.RenameWithError (141 ms)

BaseFileTest.RenameWithError (run #3):
[ RUN      ] BaseFileTest.RenameWithError
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(473):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] BaseFileTest.RenameWithError (140 ms)

BaseFileTest.RenameWithError (run #4):
[ RUN      ] BaseFileTest.RenameWithError
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(473):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] BaseFileTest.RenameWithError (140 ms)

(view as text)
BaseFileTest.RenameWithErrorInProgress (run #1):
[ RUN      ] BaseFileTest.RenameWithErrorInProgress
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(500):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(511):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] BaseFileTest.RenameWithErrorInProgress (187 ms)

BaseFileTest.RenameWithErrorInProgress (run #2):
[ RUN      ] BaseFileTest.RenameWithErrorInProgress
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(500):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(511):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] BaseFileTest.RenameWithErrorInProgress (141 ms)

BaseFileTest.RenameWithErrorInProgress (run #3):
[ RUN      ] BaseFileTest.RenameWithErrorInProgress
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(500):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(511):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] BaseFileTest.RenameWithErrorInProgress (140 ms)

BaseFileTest.RenameWithErrorInProgress (run #4):
[ RUN      ] BaseFileTest.RenameWithErrorInProgress
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(500):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
c:\b\build\slave\win_builder\build\src\content\browser\download\base_file_unittest.cc(511):
error: Value of: base_file_->Rename(new_path)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] BaseFileTest.RenameWithErrorInProgress (140 ms)

(view as text)
DownloadFile/DownloadFileTestWithRename.RenameError/0 (run #1):
[ RUN      ] DownloadFile/DownloadFileTestWithRename.RenameError/0
c:\b\build\slave\win_builder\build\src\content\browser\download\download_file_unittest.cc(573):
error: Value of: InvokeSelectedRenameMethod(target_path, 0)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] DownloadFile/DownloadFileTestWithRename.RenameError/0, where
GetParam() = 4-byte object \u003C64-8D 27-02> (0 ms)

DownloadFile/DownloadFileTestWithRename.RenameError/0 (run #2):
[ RUN      ] DownloadFile/DownloadFileTestWithRename.RenameError/0
c:\b\build\slave\win_builder\build\src\content\browser\download\download_file_unittest.cc(573):
error: Value of: InvokeSelectedRenameMethod(target_path, 0)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] DownloadFile/DownloadFileTestWithRename.RenameError/0, where
GetParam() = 4-byte object \u003C64-8D 27-02> (16 ms)

DownloadFile/DownloadFileTestWithRename.RenameError/0 (run #3):
[ RUN      ] DownloadFile/DownloadFileTestWithRename.RenameError/0
c:\b\build\slave\win_builder\build\src\content\browser\download\download_file_unittest.cc(573):
error: Value of: InvokeSelectedRenameMethod(target_path, 0)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] DownloadFile/DownloadFileTestWithRename.RenameError/0, where
GetParam() = 4-byte object \u003C64-8D 27-02> (15 ms)

DownloadFile/DownloadFileTestWithRename.RenameError/0 (run #4):
[ RUN      ] DownloadFile/DownloadFileTestWithRename.RenameError/0
c:\b\build\slave\win_builder\build\src\content\browser\download\download_file_unittest.cc(573):
error: Value of: InvokeSelectedRenameMethod(target_path, 0)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] DownloadFile/DownloadFileTestWithRename.RenameError/0, where
GetParam() = 4-byte object \u003C64-8D 27-02> (16 ms)

(view as text)
DownloadFile/DownloadFileTestWithRename.RenameError/1 (run #1):
[ RUN      ] DownloadFile/DownloadFileTestWithRename.RenameError/1
c:\b\build\slave\win_builder\build\src\content\browser\download\download_file_unittest.cc(573):
error: Value of: InvokeSelectedRenameMethod(target_path, 0)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] DownloadFile/DownloadFileTestWithRename.RenameError/1, where
GetParam() = 4-byte object \u003CAB-AB 03-01> (16 ms)

DownloadFile/DownloadFileTestWithRename.RenameError/1 (run #2):
[ RUN      ] DownloadFile/DownloadFileTestWithRename.RenameError/1
c:\b\build\slave\win_builder\build\src\content\browser\download\download_file_unittest.cc(573):
error: Value of: InvokeSelectedRenameMethod(target_path, 0)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] DownloadFile/DownloadFileTestWithRename.RenameError/1, where
GetParam() = 4-byte object \u003CAB-AB 03-01> (15 ms)

DownloadFile/DownloadFileTestWithRename.RenameError/1 (run #3):
[ RUN      ] DownloadFile/DownloadFileTestWithRename.RenameError/1
c:\b\build\slave\win_builder\build\src\content\browser\download\download_file_unittest.cc(573):
error: Value of: InvokeSelectedRenameMethod(target_path, 0)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] DownloadFile/DownloadFileTestWithRename.RenameError/1, where
GetParam() = 4-byte object \u003CAB-AB 03-01> (16 ms)

DownloadFile/DownloadFileTestWithRename.RenameError/1 (run #4):
[ RUN      ] DownloadFile/DownloadFileTestWithRename.RenameError/1
c:\b\build\slave\win_builder\build\src\content\browser\download\download_file_unittest.cc(573):
error: Value of: InvokeSelectedRenameMethod(target_path, 0)
  Actual: 10
Expected: DOWNLOAD_INTERRUPT_REASON_FILE_ACCESS_DENIED
Which is: 2
[  FAILED  ] DownloadFile/DownloadFileTestWithRename.RenameError/1, where
GetParam() = 4-byte object \u003CAB-AB 03-01> (16 ms)


On Thu, Jun 19, 2014 at 5:03 PM, <yzshen@chromium.org> wrote:

> Committed patchset #1 manually as r278537 (tree was closed).
>
> https://codereview.chromium.org/342233002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698