Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: trunk/src/content/browser/download/base_file.h

Issue 342233002: Revert 278483 "[Downloads] Retry renames after transient failures." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/content/browser/download/base_file.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/content/browser/download/base_file.h
===================================================================
--- trunk/src/content/browser/download/base_file.h (revision 278536)
+++ trunk/src/content/browser/download/base_file.h (working copy)
@@ -56,10 +56,7 @@
DownloadInterruptReason AppendDataToFile(const char* data, size_t data_len);
// Rename the download file. Returns a DownloadInterruptReason indicating the
- // result of the operation. A return code of NONE indicates that the rename
- // was successful. After a failure, the full_path() and in_progress() can be
- // used to determine the last known filename and whether the file is available
- // for writing or retrying the rename.
+ // result of the operation.
virtual DownloadInterruptReason Rename(const base::FilePath& full_path);
// Detach the file so it is not deleted on destruction.
@@ -82,15 +79,8 @@
// Windows to ensure the correct app client ID is available.
DownloadInterruptReason AnnotateWithSourceInformation();
- // Returns the last known path to the download file. Can be empty if there's
- // no file.
- const base::FilePath& full_path() const { return full_path_; }
-
- // Returns true if the file is open. If true, the file can be written to or
- // renamed.
+ base::FilePath full_path() const { return full_path_; }
bool in_progress() const { return file_.IsValid(); }
-
- // Returns the number of bytes in the file pointed to by full_path().
int64 bytes_so_far() const { return bytes_so_far_; }
// Fills |hash| with the hash digest for the file.
« no previous file with comments | « no previous file | trunk/src/content/browser/download/base_file.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698