Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: trunk/src/tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 342233002: Revert 278483 "[Downloads] Retry renames after transient failures." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « trunk/src/content/public/browser/download_interrupt_reason_values.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/metrics/histograms/histograms.xml
===================================================================
--- trunk/src/tools/metrics/histograms/histograms.xml (revision 278536)
+++ trunk/src/tools/metrics/histograms/histograms.xml (working copy)
@@ -4736,15 +4736,6 @@
</summary>
</histogram>
-<histogram name="Download.MapWinShErrorTransientError"
- enum="SpecialShFileOperationCodes">
- <owner>asanka@chromium.org</owner>
- <summary>
- Windows error that produced a DOWNLOAD_INTERRUPT_REASON_FILE_TRANSIENT_ERROR
- result in MapShFileOperationCodes().
- </summary>
-</histogram>
-
<histogram name="Download.OnChanged">
<owner>asanka@chromium.org</owner>
<summary>
@@ -4878,24 +4869,6 @@
<summary>Time between the start of a download and its completion.</summary>
</histogram>
-<histogram name="Download.TimeToRenameFailureAfterInitialFailure"
- units="milliseconds">
- <owner>asanka@chromium.org</owner>
- <summary>
- Time elapsed until a retried download file rename operation failed for the
- last time after the initial rename failed.
- </summary>
-</histogram>
-
-<histogram name="Download.TimeToRenameSuccessAfterInitialFailure"
- units="milliseconds">
- <owner>asanka@chromium.org</owner>
- <summary>
- Time elapsed until a retried download file rename operation succeeded after
- the initial rename failed.
- </summary>
-</histogram>
-
<histogram name="Download.UserDiscard" enum="DownloadItem.DangerType">
<owner>asanka@chromium.org</owner>
<owner>felt@chromium.org</owner>
@@ -44113,9 +44086,7 @@
<enum name="SpecialShFileOperationCodes" type="int">
<summary>Legacy error codes still returned by |ShFileOperation()|</summary>
- <int value="5" label="Access denied (Win32)"/>
- <int value="32" label="Sharing violation (Win32)"/>
- <int value="87" label="Invalid parameter (Win32)"/>
+ <int value="5" label="Access denied"/>
<int value="113" label="Source and Destination are same file"/>
<int value="114" label="Multiple source mapped to single destination"/>
<int value="115" label="Rename to different directory"/>
« no previous file with comments | « trunk/src/content/public/browser/download_interrupt_reason_values.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698