Issue 342203004: Get rid of compositing and squashing helper methods on RenderLayerModelObject.

Issue 342203004: Get rid of compositing and squashing helper methods on RenderLayerModelObject. (Closed)

Created:
6 years, 6 months ago by chrishtr

Modified:
6 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Get rid of compositing and squashing helper methods on RenderLayerModelObject. Calling them is basically a layering violation, so it should not be encouraged. Also made one method of RenderObject private that is already used as such, and updated RenderLayerClipper::clippingRootForPainting to use an already-available method on RenderLayer that is also used by RenderLayer::enclosingCompositingLayerForPaintInvalidation. This method does almost the same thing as RenderLayerClipper::clippingRootForPainting is intended to do; the latter just throws in an if(transform()). BUG=384520 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177055

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -45 lines)			Patch
M	Source/core/rendering/RenderLayer.cpp	View	1 2	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderLayerClipper.cpp	View		1 chunk	+8 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderLayerModelObject.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderLayerModelObject.cpp	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	Source/core/rendering/RenderLayerRepainter.cpp	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/rendering/RenderLayerScrollableArea.cpp	View	1 2 3	7 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/core/rendering/RenderObject.h	View	1 2	2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/rendering/RenderSelectionInfo.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/rendering/compositing/RenderLayerCompositor.cpp	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download