Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1334)

Unified Diff: Source/core/rendering/RenderSelectionInfo.h

Issue 342203004: Get rid of compositing and squashing helper methods on RenderLayerModelObject. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed compile. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderSelectionInfo.h
diff --git a/Source/core/rendering/RenderSelectionInfo.h b/Source/core/rendering/RenderSelectionInfo.h
index c41f9ccc5635679c5fe02ca258c533cf144fb5df..5677ed42d6bd16aad9d88b4f06de381eed1b166e 100644
--- a/Source/core/rendering/RenderSelectionInfo.h
+++ b/Source/core/rendering/RenderSelectionInfo.h
@@ -66,7 +66,7 @@ public:
if (o->canUpdateSelectionOnRootLineBoxes()) {
m_rect = o->selectionRectForPaintInvalidation(m_repaintContainer, clipToVisibleContent);
// FIXME: groupedMapping() leaks the squashing abstraction. See RenderBlockSelectionInfo for more details.
- if (m_repaintContainer && m_repaintContainer->groupedMapping())
+ if (m_repaintContainer && m_repaintContainer->layer()->groupedMapping())
RenderLayer::mapRectToPaintInvalidationBacking(m_repaintContainer, m_repaintContainer, m_rect);
} else {
m_rect = LayoutRect();
@@ -103,7 +103,7 @@ public:
// FIXME: this is leaking the squashing abstraction. However, removing the groupedMapping() condiitional causes
// RenderBox::mapRectToPaintInvalidationBacking to get called, which makes rect adjustments even if you pass the same
// repaintContainer as the render object. Find out why it does that and fix.
- if (m_repaintContainer && m_repaintContainer->groupedMapping())
+ if (m_repaintContainer && m_repaintContainer->layer()->groupedMapping())
RenderLayer::mapRectToPaintInvalidationBacking(m_repaintContainer, m_repaintContainer, repaintRect);
m_object->invalidatePaintUsingContainer(m_repaintContainer, enclosingIntRect(repaintRect), InvalidationSelection);
}
« no previous file with comments | « Source/core/rendering/RenderObject.h ('k') | Source/core/rendering/compositing/RenderLayerCompositor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698