Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 342153003: Add ChromeVox braille_util_test to chromevox_tests. (Closed)

Created:
6 years, 6 months ago by Peter Lundblad
Modified:
6 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Add ChromeVox braille_util_test to chromevox_tests. Based on work by dmazzoni@chromium.org in https://codereview.chromium.org/339923002/ with the addition of support for including the English text messages in tests and other minor fixes. BUG=371692 R=dmazzoni@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278694

Patch Set 1 #

Messages

Total messages: 8 (0 generated)
Peter Lundblad
6 years, 6 months ago (2014-06-19 07:27:04 UTC) #1
dmazzoni
lgtm Thanks!
6 years, 6 months ago (2014-06-19 23:28:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/342153003/1
6 years, 6 months ago (2014-06-19 23:30:49 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-20 07:57:01 UTC) #4
commit-bot: I haz the power
Change committed as 278694
6 years, 6 months ago (2014-06-20 13:16:48 UTC) #5
dmazzoni
This seems to be failing when I check out a fresh build and run these ...
6 years, 6 months ago (2014-06-23 07:34:21 UTC) #6
Peter Lundblad
Hi, Sent out a fix for this. https://codereview.chromium.org/350653006 I don't know why my local run ...
6 years, 6 months ago (2014-06-23 23:25:37 UTC) #7
dmazzoni
6 years, 6 months ago (2014-06-24 05:54:31 UTC) #8
Thanks. I'll send out the patch to add this test target to the bots now. :)


On Mon, Jun 23, 2014 at 4:25 PM, <plundblad@chromium.org> wrote:

> Hi,
>
> Sent out a fix for this. https://codereview.chromium.org/350653006
>
> I don't know why my local run was with messages from the previous
> upstream.  I think getting this new test target on the bots will be
> helpful :-)
>
> Thanks,
> //Peter
>
> Dominic Mazzoni writes:
> > This seems to be failing when I check out a fresh build and run these
> tests.
> > Could you take a look?
> >
> >
> > On Fri, Jun 20, 2014 at 6:16 AM, <commit-bot@chromium.org> wrote:
> >
> >     Change committed as 278694
> >
> >     https://codereview.chromium.org/342153003/
> >
> >
>
> --
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698