Issue 350653006: Fix chromevox_tests that depend on actual message strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 350653006: Fix chromevox_tests that depend on actual message strings. (Closed)

Created:
6 years, 6 months ago by Peter Lundblad

Modified:
6 years, 6 months ago

Reviewers:
dmazzoni

CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix chromevox_tests that depend on actual message strings. The JSON messages generated by grit violate some assumptions made by the test messages implementation which was written based on the previous upstream ChromeVox messages. these differences don't matter for for the chrome.i18n APIs, so we adjust the test messages implementation. BUG=371692 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279334

Patch Set 1 #

Patch Set 2 : Split out fix for mock4js. #

Total comments: 1

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -21 lines)			Patch
	M	chrome/browser/resources/chromeos/chromevox/host/testing/msgs.js	View		1 chunk	+4 lines, -21 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

dmazzoni

lgtm https://codereview.chromium.org/350653006/diff/20001/chrome/browser/resources/chromeos/chromevox/host/testing/msgs.js File chrome/browser/resources/chromeos/chromevox/host/testing/msgs.js (left): https://codereview.chromium.org/350653006/diff/20001/chrome/browser/resources/chromeos/chromevox/host/testing/msgs.js#oldcode64 chrome/browser/resources/chromeos/chromevox/host/testing/msgs.js:64: // Allow tests to substitute the string 'dummy' ...

6 years, 6 months ago (2014-06-24 05:54:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/plundblad@chromium.org/350653006/20001

6 years, 6 months ago (2014-06-24 05:55:13 UTC) #3

Message was sent while issue was closed.

Change committed as 279334

Expand Messages | Collapse Messages