Mark all tests in the DownloadTest suite as flaky under Windows

Mark all tests in the DownloadTest suite as flaky under Windows (as discussed in this review).

As discussed under http://codereview.chromium.org/342056 .

Note: did not change that ContentDisposition test, which  was already marked as FLAKY for all platforms, nor KnownSize, which is DISABLED.

BUG=20809
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31549

[Nico, 2009-10-30 14:53:41]

For the records (already said this in irc):

This happens only on vista (dbg), and the test fails with:

DownloadTest.PerWindowShelf:
C:\b\slave\chromium-dbg-builder\build\src\chrome\browser\download\download_uitest.cc(170):
error: Failed
Could not detect Internet ZoneIndentifier

Looks more like an unhealthy bot than a flaky test.

[Paweł Hajdan Jr., 2009-10-30 14:55:08]

Drive-by:

All of DownloadTest.* are going to be flaky that way. See http://crbug.com/20809
(and please put the reference in the commit message).

If you're marking this test as flaky, please mark all of them in this group.

[Paweł Hajdan Jr., 2009-10-30 14:57:23]

I'm quite sure this is flakiness. Adding cpu, maybe there are some things that
can be checked on the bot etc.

[Nico, 2009-10-30 15:07:23]

The ZoneIdentifier stuff should only be flaky on windows, and it's not
_that_ flaky usually. Marking them all as flaky will hide real
problems.

Is it possible to mark tests as flaky on windows only?

On Fri, Oct 30, 2009 at 7:57 AM,  <phajdan.jr@chromium.org> wrote:
> I'm quite sure this is flakiness. Adding cpu, maybe there are some things
> that
> can be checked on the bot etc.
>
> http://codereview.chromium.org/342056
>

[Roland Steiner, 2009-10-30 15:09:03]

On 2009/10/30 14:57:23, Paweł Hajdan Jr. wrote:
> I'm quite sure this is flakiness. Adding cpu, maybe there are some things that
> can be checked on the bot etc.

Holding off on this for now, as this could have been caused by server flakiness
as well.

[Roland Steiner, 2009-10-30 15:18:10]

On 2009/10/30 15:07:23, Nico wrote:
> Is it possible to mark tests as flaky on windows only?

BUG_xyz WIN <test> = PASS FAIL

should work.

[Roland Steiner, 2009-10-30 15:20:12]

On 2009/10/30 15:18:10, Roland Steiner wrote:
> BUG_xyz WIN <test> = PASS FAIL

ARGH, UI Tests, NOT Layout tests! >_< that's what you get when looking after too
many hours! Really time to get some sleep! >_<

[cpu_(ooo_6.6-7.5), 2009-11-06 01:23:22]

was this CL abandoned? and if so can we close it?

[Roland Steiner, 2009-11-06 09:12:04]

I'm not sure what the consensus was what should be done about this one (whether
to abandon it, to mark just that one test, or all of them).

[Nico, 2009-11-06 15:12:40]

Is it still flaky? If so, mark just that one test, and only on
windows. If not, abandon this CL.

On Fri, Nov 6, 2009 at 1:12 AM,  <rolandsteiner@chromium.org> wrote:
> I'm not sure what the consensus was what should be done about this one
> (whether
> to abandon it, to mark just that one test, or all of them).
>
> http://codereview.chromium.org/342056
>

[Paweł Hajdan Jr., 2009-11-06 15:46:17]

On 2009/11/06 15:12:40, Nico wrote:
> Is it still flaky? If so, mark just that one test, and only on
> windows. If not, abandon this CL.

Yes, it is still flaky, all tests in this group, only on Windows. I suggest
marking all the tests in this group as flaky (only on Windows).

[Roland Steiner, 2009-11-10 07:49:07]

Uploaded a new patch that marks all tests as FLAKY under Windows, except
'ContentDisposition' (already FLAKY on all platforms) and 'KnownSize'
(DISABLED).

Also changed the bug description accordingly.

[Paweł Hajdan Jr., 2009-11-10 07:52:14]

Please make sure that each test marked as FLAKYONWIN has a link to
http://crbug.com/20809 describing why it's flaky.

After that, LGTM.