Mark all tests in the DownloadTest suite as flaky under Windows

chrome/browser/download/download_uitest.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <sstream>
 #include <string>
 
 #include "build/build_config.h"
 #if defined(OS_WIN)
 #include <shlwapi.h>
 #endif
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/path_service.h"
 #include "base/platform_thread.h"
 #include "base/string_util.h"
 #include "chrome/app/chrome_dll_resource.h"
 #include "chrome/browser/net/url_request_mock_http_job.h"
 #include "chrome/browser/net/url_request_slow_download_job.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/ui/ui_test.h"
 #include "chrome/test/automation/tab_proxy.h"
 #include "chrome/test/automation/browser_proxy.h"
 #include "net/base/net_util.h"
 #include "net/url_request/url_request_unittest.h"
 
+#if defined(OS_WIN)
+#define FLAKYONWIN(Test) FLAKY_ ## Test
+#else
+#define FLAKYONWIN(Test) Test
+#endif
+
 namespace {
 
 const wchar_t kDocRoot[] = L"chrome/test/data";
 
 #if defined(OS_WIN)
 // Checks if the volume supports Alternate Data Streams. This is required for
 // the Zone Identifier implementation.
 bool VolumeSupportsADS(const std::wstring path) {
   wchar_t drive[MAX_PATH] = {0};
   wcscpy_s(drive, MAX_PATH, path.c_str());
@@ skipping 129 matching lines @@
 
     FAIL() << "Could not detect Internet ZoneIndentifier";
   }
 #endif  // defined(OS_WIN)
 
   FilePath download_prefix_;
 };
 
 // Download a file with non-viewable content, verify that the
 // download tab opened and the file exists.
-TEST_F(DownloadTest, DownloadMimeType) {
+TEST_F(DownloadTest, FLAKYONWIN(DownloadMimeType)) {
   FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
 
   EXPECT_EQ(1, GetTabCount());
 
   NavigateToURL(URLRequestMockHTTPJob::GetMockUrl(file));
   // No new tabs created, downloads appear in the current tab's download shelf.
   WaitUntilTabCount(1);
 
   // Wait until the file is downloaded.
   PlatformThread::Sleep(action_timeout_ms());
 
   CleanUpDownload(file);
 
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
   EXPECT_TRUE(WaitForDownloadShelfVisible(browser.get()));
 }
 
 // Access a file with a viewable mime-type, verify that a download
 // did not initiate.
-TEST_F(DownloadTest, NoDownload) {
+TEST_F(DownloadTest, FLAKYONWIN(NoDownload)) {
   FilePath file(FILE_PATH_LITERAL("download-test2.html"));
   FilePath file_path = download_prefix_.Append(file);
 
   if (file_util::PathExists(file_path))
     ASSERT_TRUE(file_util::Delete(file_path, false));
 
   EXPECT_EQ(1, GetTabCount());
 
   NavigateToURL(URLRequestMockHTTPJob::GetMockUrl(file));
   WaitUntilTabCount(1);
@@ skipping 31 matching lines @@
   // Ensure the download shelf is visible on the window.
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   ASSERT_TRUE(browser.get());
   EXPECT_TRUE(WaitForDownloadShelfVisible(browser.get()));
 }
 
 // Test that the download shelf is per-window by starting a download in one
 // tab, opening a second tab, closing the shelf, going back to the first tab,
 // and checking that the shelf is closed.
 // See bug http://crbug.com/26325
-TEST_F(DownloadTest, FLAKY_PerWindowShelf) {
+TEST_F(DownloadTest, FLAKYONWIN(PerWindowShelf)) {
   FilePath file(FILE_PATH_LITERAL("download-test3.gif"));
   FilePath download_file(FILE_PATH_LITERAL("download-test3-attachment.gif"));
 
   EXPECT_EQ(1, GetTabCount());
 
   NavigateToURL(URLRequestMockHTTPJob::GetMockUrl(file));
   WaitUntilTabCount(1);
 
   // Wait until the file is downloaded.
   PlatformThread::Sleep(action_timeout_ms());
@@ skipping 24 matching lines @@
   ASSERT_FALSE(shelf_visible);
 }
 
 // UnknownSize and KnownSize are tests which depend on
 // URLRequestSlowDownloadJob to serve content in a certain way. Data will be
 // sent in two chunks where the first chunk is 35K and the second chunk is 10K.
 // The test will first attempt to download a file; but the server will "pause"
 // in the middle until the server receives a second request for
 // "download-finish.  At that time, the download will finish.
 // Flaky on Linux: http://code.google.com/p/chromium/issues/detail?id=14746
-TEST_F(DownloadTest, UnknownSize) {
+TEST_F(DownloadTest, FLAKYONWIN(UnknownSize)) {
   GURL url(URLRequestSlowDownloadJob::kUnknownSizeUrl);
   FilePath filename;
   net::FileURLToFilePath(url, &filename);
   filename = filename.BaseName();
   RunSizeTest(url, L"32.0 KB - " + filename.ToWStringHack(),
               L"100% - " + filename.ToWStringHack());
 }
 
 // http://b/1158253
 TEST_F(DownloadTest, DISABLED_KnownSize) {
   GURL url(URLRequestSlowDownloadJob::kKnownSizeUrl);
   FilePath filename;
   net::FileURLToFilePath(url, &filename);
   filename = filename.BaseName();
   RunSizeTest(url, L"71% - " + filename.ToWStringHack(),
               L"100% - " + filename.ToWStringHack());
 }
 
 // Test that when downloading an item in Incognito mode, we don't crash when
 // closing the last Incognito window (http://crbug.com/13983).
-TEST_F(DownloadTest, IncognitoDownload) {
+TEST_F(DownloadTest, FLAKYONWIN(IncognitoDownload)) {
   // Open a regular window and sanity check default values for window / tab
   // count and shelf visibility.
   scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
   int window_count = 0;
   ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
   ASSERT_EQ(1, window_count);
   EXPECT_EQ(1, GetTabCount());
   bool is_shelf_visible;
   browser->IsShelfVisible(&is_shelf_visible);
   EXPECT_FALSE(is_shelf_visible);
@@ skipping 20 matching lines @@
   ASSERT_EQ(1, window_count);
 
   // Verify that the regular window does not have a download shelf.
   browser->IsShelfVisible(&is_shelf_visible);
   EXPECT_FALSE(is_shelf_visible);
 
   CleanUpDownload(file);
 }
 
 }  // namespace
+
+#undef FLAKYONWIN
+