Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6070)

Unified Diff: chrome/browser/download/download_uitest.cc

Issue 342056: Mark all tests in the DownloadTest suite as flaky under Windows (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_uitest.cc
===================================================================
--- chrome/browser/download/download_uitest.cc (revision 31504)
+++ chrome/browser/download/download_uitest.cc (working copy)
@@ -27,6 +27,12 @@
#include "net/base/net_util.h"
#include "net/url_request/url_request_unittest.h"
+#if defined(OS_WIN)
+#define FLAKYONWIN(Test) FLAKY_ ## Test
+#else
+#define FLAKYONWIN(Test) Test
+#endif
+
namespace {
const wchar_t kDocRoot[] = L"chrome/test/data";
@@ -176,7 +182,7 @@
// Download a file with non-viewable content, verify that the
// download tab opened and the file exists.
-TEST_F(DownloadTest, DownloadMimeType) {
+TEST_F(DownloadTest, FLAKYONWIN(DownloadMimeType)) {
FilePath file(FILE_PATH_LITERAL("download-test1.lib"));
EXPECT_EQ(1, GetTabCount());
@@ -197,7 +203,7 @@
// Access a file with a viewable mime-type, verify that a download
// did not initiate.
-TEST_F(DownloadTest, NoDownload) {
+TEST_F(DownloadTest, FLAKYONWIN(NoDownload)) {
FilePath file(FILE_PATH_LITERAL("download-test2.html"));
FilePath file_path = download_prefix_.Append(file);
@@ -249,7 +255,7 @@
// tab, opening a second tab, closing the shelf, going back to the first tab,
// and checking that the shelf is closed.
// See bug http://crbug.com/26325
-TEST_F(DownloadTest, FLAKY_PerWindowShelf) {
+TEST_F(DownloadTest, FLAKYONWIN(PerWindowShelf)) {
FilePath file(FILE_PATH_LITERAL("download-test3.gif"));
FilePath download_file(FILE_PATH_LITERAL("download-test3-attachment.gif"));
@@ -294,7 +300,7 @@
// in the middle until the server receives a second request for
// "download-finish. At that time, the download will finish.
// Flaky on Linux: http://code.google.com/p/chromium/issues/detail?id=14746
-TEST_F(DownloadTest, UnknownSize) {
+TEST_F(DownloadTest, FLAKYONWIN(UnknownSize)) {
GURL url(URLRequestSlowDownloadJob::kUnknownSizeUrl);
FilePath filename;
net::FileURLToFilePath(url, &filename);
@@ -315,7 +321,7 @@
// Test that when downloading an item in Incognito mode, we don't crash when
// closing the last Incognito window (http://crbug.com/13983).
-TEST_F(DownloadTest, IncognitoDownload) {
+TEST_F(DownloadTest, FLAKYONWIN(IncognitoDownload)) {
// Open a regular window and sanity check default values for window / tab
// count and shelf visibility.
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
@@ -356,3 +362,6 @@
}
} // namespace
+
+#undef FLAKYONWIN
+
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698