Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 341923006: Revert 278342 "Convert sticky keys to a chromeos::EventRewriter ..." (Closed)

Created:
6 years, 6 months ago by oshima
Modified:
6 years, 6 months ago
Reviewers:
kpschoedel
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 278342 "Convert sticky keys to a chromeos::EventRewriter ..." > Convert sticky keys to a chromeos::EventRewriter phase. > > BUG=354035 > TEST=unit_tests,ash_unittests,manual > R=sadrul@chromium.org,derat@chromium.org > > Review URL: https://codereview.chromium.org/255033003 TBR=kpschoedel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1225 lines, -1111 lines) Patch
M trunk/src/ash/shell.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M trunk/src/ash/sticky_keys/sticky_keys_controller.h View 6 chunks +68 lines, -96 lines 0 comments Download
M trunk/src/ash/sticky_keys/sticky_keys_controller.cc View 10 chunks +310 lines, -183 lines 0 comments Download
M trunk/src/ash/sticky_keys/sticky_keys_overlay_unittest.cc View 2 chunks +197 lines, -3 lines 0 comments Download
M trunk/src/ash/sticky_keys/sticky_keys_unittest.cc View 18 chunks +554 lines, -259 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/events/event_rewriter.h View 5 chunks +2 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/events/event_rewriter.cc View 7 chunks +33 lines, -105 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/events/event_rewriter_unittest.cc View 35 chunks +48 lines, -438 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
oshima
6 years, 6 months ago (2014-06-19 17:58:41 UTC) #1
oshima
6 years, 6 months ago (2014-06-19 17:58:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r278419.

Powered by Google App Engine
This is Rietveld 408576698