Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: trunk/src/ash/shell.cc

Issue 341923006: Revert 278342 "Convert sticky keys to a chromeos::EventRewriter ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/ash/sticky_keys/sticky_keys_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/ash/shell.cc
===================================================================
--- trunk/src/ash/shell.cc (revision 278418)
+++ trunk/src/ash/shell.cc (working copy)
@@ -889,6 +889,13 @@
// The order in which event filters are added is significant.
+#if defined(OS_CHROMEOS)
+ // The StickyKeysController also rewrites events and must be added
+ // before observers, but after the EventRewriterEventFilter.
+ sticky_keys_controller_.reset(new StickyKeysController);
+ AddPreTargetHandler(sticky_keys_controller_.get());
+#endif
+
// wm::UserActivityDetector passes events to observers, so let them get
// rewritten first.
user_activity_detector_.reset(new ::wm::UserActivityDetector);
@@ -923,10 +930,6 @@
keyboard::InitializeKeyboard();
#endif
-#if defined(OS_CHROMEOS)
- sticky_keys_controller_.reset(new StickyKeysController);
-#endif
-
lock_state_controller_.reset(new LockStateController);
power_button_controller_.reset(new PowerButtonController(
lock_state_controller_.get()));
« no previous file with comments | « no previous file | trunk/src/ash/sticky_keys/sticky_keys_controller.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698