Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 341433007: Revert of Support using OpenGL ES context on desktop (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Support using OpenGL ES context on desktop (https://codereview.chromium.org/319043005/) Reason for revert: Breaks unit tests on ANGLE bot. Original issue's description: > Support using OpenGL ES context on desktop > > Support using OpenGL ES context on desktop for unix and Android platforms. This > is mainly useful in development. > > Add --gpuAPI flag to gm, dm, bench, bench_pictures and render_pictures. The > possible parameters for the flag are "gl" and "gles". > > Committed: https://skia.googlesource.com/skia/+/80549fcdd50269d7e069d6db02b395fca128056c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+370 lines, -648 lines) Patch
M bench/benchmain.cpp View 5 chunks +3 lines, -25 lines 0 comments Download
M dm/DM.cpp View 8 chunks +20 lines, -42 lines 0 comments Download
M dm/DMBenchTask.h View 2 chunks +0 lines, -2 lines 0 comments Download
M dm/DMBenchTask.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M dm/DMGpuGMTask.h View 2 chunks +0 lines, -2 lines 0 comments Download
M dm/DMGpuGMTask.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M dm/DMGpuSupport.h View 3 chunks +1 line, -9 lines 0 comments Download
M experimental/PdfViewer/pdf_viewer_main.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/gmmain.cpp View 13 chunks +9 lines, -43 lines 0 comments Download
M include/gpu/GrContextFactory.h View 3 chunks +5 lines, -7 lines 0 comments Download
M include/gpu/gl/SkANGLEGLContext.h View 1 chunk +1 line, -2 lines 0 comments Download
M include/gpu/gl/SkDebugGLContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/SkGLContextHelper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M include/gpu/gl/SkMesaGLContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/SkNativeGLContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/gpu/gl/SkNullGLContext.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkWGL.h View 1 chunk +1 line, -11 lines 0 comments Download
D src/gpu/gl/GrGLAssembleGLESInterface.h View 1 chunk +0 lines, -256 lines 0 comments Download
M src/gpu/gl/SkGLContextHelper.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/gpu/gl/SkNullGLContext.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp View 1 chunk +239 lines, -10 lines 0 comments Download
M src/gpu/gl/android/SkNativeGLContext_android.cpp View 2 chunks +2 lines, -11 lines 0 comments Download
M src/gpu/gl/angle/SkANGLEGLContext.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/gl/debug/SkDebugGLContext.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/gpu/gl/iOS/SkNativeGLContext_iOS.mm View 2 chunks +2 lines, -6 lines 0 comments Download
M src/gpu/gl/mac/SkNativeGLContext_mac.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M src/gpu/gl/mesa/SkMesaGLContext.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/gpu/gl/nacl/SkNativeGLContext_nacl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/unix/GrGLCreateNativeInterface_unix.cpp View 2 chunks +1 line, -20 lines 0 comments Download
M src/gpu/gl/unix/SkNativeGLContext_unix.cpp View 2 chunks +41 lines, -49 lines 0 comments Download
M src/gpu/gl/win/GrGLCreateNativeInterface_win.cpp View 2 chunks +1 line, -21 lines 0 comments Download
M src/gpu/gl/win/SkNativeGLContext_win.cpp View 2 chunks +3 lines, -7 lines 0 comments Download
M src/utils/win/SkWGL_win.cpp View 2 chunks +20 lines, -37 lines 0 comments Download
M src/views/win/SkOSWindow_win.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M tools/PictureRenderer.h View 2 chunks +1 line, -5 lines 0 comments Download
M tools/PictureRenderingFlags.cpp View 4 chunks +1 line, -31 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bsalomon
Created Revert of Support using OpenGL ES context on desktop
6 years, 5 months ago (2014-06-30 15:36:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/341433007/1
6 years, 5 months ago (2014-06-30 15:36:29 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-06-30 15:36:29 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
6 years, 5 months ago (2014-06-30 15:36:30 UTC) #4
mtklein
lgtm
6 years, 5 months ago (2014-06-30 15:36:57 UTC) #5
bsalomon
The CQ bit was unchecked by bsalomon@google.com
6 years, 5 months ago (2014-06-30 15:55:36 UTC) #6
bsalomon
6 years, 5 months ago (2014-06-30 15:55:55 UTC) #7
I now have a fix, killing this revert.

Powered by Google App Engine
This is Rietveld 408576698