Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 341123005: Disable getMediaDevices tests. Revert to use getSources instead for getUserMedia tests. (Closed)

Created:
6 years, 5 months ago by Henrik Grunell
Modified:
6 years, 5 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, wjia+watch_chromium.org, mcasas+watch_chromium.org, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Disable getMediaDevices tests. Revert to use getSources instead for getUserMedia tests. getMediaDevices was landed for M37 but the spec changed just at the M37 cut without a heads-up. So we are removing getMediaDevices and replacing it with MediaDevices.enumerateDevices for M38. CL that removes the interface in blink: https://codereview.chromium.org/357303002/ NOTRY=true BUG=388648 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281262

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review + rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -17 lines) Patch
M chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc View 1 4 chunks +10 lines, -2 lines 0 comments Download
M chrome/test/data/webrtc/media_devices.js View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/media/webrtc_getusermedia_browsertest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M content/test/data/media/getusermedia.html View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Henrik Grunell
6 years, 5 months ago (2014-06-30 12:50:48 UTC) #1
Henrik Grunell
Ping for review.
6 years, 5 months ago (2014-07-03 07:51:47 UTC) #2
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/341123005/diff/1/chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc File chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc (right): https://codereview.chromium.org/341123005/diff/1/chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc#newcode184 chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc:184: // getMediaDevices is removed and will be replaced ...
6 years, 5 months ago (2014-07-03 09:43:04 UTC) #3
Henrik Grunell
https://codereview.chromium.org/341123005/diff/1/chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc File chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc (right): https://codereview.chromium.org/341123005/diff/1/chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc#newcode184 chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc:184: // getMediaDevices is removed and will be replaced On ...
6 years, 5 months ago (2014-07-03 10:44:48 UTC) #4
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 5 months ago (2014-07-03 10:45:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/341123005/20001
6 years, 5 months ago (2014-07-03 10:46:27 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium ...
6 years, 5 months ago (2014-07-03 12:43:22 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-03 12:54:30 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/167191)
6 years, 5 months ago (2014-07-03 12:54:31 UTC) #9
Henrik Grunell
The CQ bit was checked by grunell@chromium.org
6 years, 5 months ago (2014-07-03 13:07:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grunell@chromium.org/341123005/20001
6 years, 5 months ago (2014-07-03 13:08:39 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-03 13:10:12 UTC) #12
Message was sent while issue was closed.
Change committed as 281262

Powered by Google App Engine
This is Rietveld 408576698