chrome/test/data/webrtc/media_devices.js - Issue 341123005: Disable getMediaDevices tests. Revert to use getSources instead for getUserMedia tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/webrtc/media_devices.js

Issue 341123005: Disable getMediaDevices tests. Revert to use getSources instead for getUserMedia tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Code review + rebase. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc ('k') | content/browser/media/webrtc_getusermedia_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/webrtc/media_devices.js

diff --git a/chrome/test/data/webrtc/media_devices.js b/chrome/test/data/webrtc/media_devices.js

index 9a0dfb216c9c8de764ba7056febe32bbf26b412e..356184e3b5e6dbf75e148f89f0a5be47aba36613 100644

--- a/chrome/test/data/webrtc/media_devices.js

+++ b/chrome/test/data/webrtc/media_devices.js

@@ -29,7 +29,7 @@ function getSources() {

/**

* Queries for video input devices on the current system using the

- * getMediaDevices API.

+ * getSources API.

* This does not guarantee that a getUserMedia with video will succeed, as the

* camera could be busy for instance.

@@ -38,10 +38,10 @@ function getSources() {

* no-video-input-devices otherwise.

function hasVideoInputDeviceOnSystem() {

- navigator.getMediaDevices(function(devices) {

+ MediaStreamTrack.getSources(function(devices) {

var hasVideoInputDevice = false;

devices.forEach(function(device) {

- if (device.kind == 'videoinput')

+ if (device.kind == 'video')

hasVideoInputDevice = true;

});