Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 340993002: Revert of Remove NPAPI plugin from chromoting webapp. (Closed)

Created:
6 years, 6 months ago by please use gerrit instead
Modified:
6 years, 6 months ago
Reviewers:
Sergey Ulanov, weitao, Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Remove NPAPI plugin from chromoting webapp. (https://codereview.chromium.org/342583002/) Reason for revert: Broke "gclient runhooks" on http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/50669 gyp: Undefined variable plugin_file in /b/build/slave/google-chrome-rel-linux_64/build/src/remoting/remoting.gyp Original issue's description: > Remove NPAPI plugin from chromoting webapp. > > BUG=134215 > R=weitaosu@chromium.org, wez@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278198 TBR=wez@chromium.org,weitaosu@chromium.org,sergeyu@chromium.org NOTREECHECKS=true NOTRY=true BUG=134215 (Revert stopped at Sergey's request.)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3125 lines, -43 lines) Patch
M remoting/branding_Chrome View 1 chunk +1 line, -1 line 0 comments Download
M remoting/branding_Chromium View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/branding.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/chromoting_host_context.h View 1 chunk +2 lines, -1 line 0 comments Download
A remoting/host/plugin/host_log_handler.h View 1 chunk +38 lines, -0 lines 0 comments Download
A remoting/host/plugin/host_log_handler.cc View 1 chunk +123 lines, -0 lines 0 comments Download
A remoting/host/plugin/host_plugin.cc View 1 chunk +574 lines, -0 lines 0 comments Download
A remoting/host/plugin/host_plugin.def View 1 chunk +6 lines, -0 lines 0 comments Download
A remoting/host/plugin/host_plugin-Info.plist View 1 chunk +29 lines, -0 lines 0 comments Download
A remoting/host/plugin/host_plugin-InfoPlist.strings.jinja2 View 1 chunk +3 lines, -0 lines 0 comments Download
A remoting/host/plugin/host_plugin_utils.h View 1 chunk +55 lines, -0 lines 0 comments Download
A remoting/host/plugin/host_plugin_utils.cc View 1 chunk +75 lines, -0 lines 0 comments Download
A remoting/host/plugin/host_script_object.h View 1 chunk +320 lines, -0 lines 0 comments Download
A remoting/host/plugin/host_script_object.cc View 1 chunk +1143 lines, -0 lines 0 comments Download
M remoting/host/win/version.rc.jinja2 View 2 chunks +6 lines, -1 line 0 comments Download
M remoting/remoting.gyp View 3 chunks +33 lines, -2 lines 0 comments Download
M remoting/remoting_client.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/remoting_host.gypi View 2 chunks +101 lines, -0 lines 0 comments Download
M remoting/remoting_host_linux.gypi View 2 chunks +6 lines, -3 lines 0 comments Download
M remoting/remoting_host_mac.gypi View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_webapp.gypi View 5 chunks +27 lines, -0 lines 0 comments Download
M remoting/resources/remoting_strings.grd View 5 chunks +11 lines, -2 lines 0 comments Download
M remoting/webapp/build-webapp.py View 3 chunks +52 lines, -7 lines 0 comments Download
M remoting/webapp/host_controller.js View 3 chunks +37 lines, -1 line 0 comments Download
M remoting/webapp/host_dispatcher.js View 23 chunks +220 lines, -10 lines 0 comments Download
M remoting/webapp/host_it2me_dispatcher.js View 6 chunks +81 lines, -9 lines 0 comments Download
M remoting/webapp/host_screen.js View 2 chunks +17 lines, -3 lines 0 comments Download
M remoting/webapp/host_session.js View 1 chunk +8 lines, -0 lines 0 comments Download
M remoting/webapp/js_proto/remoting_proto.js View 1 chunk +129 lines, -0 lines 0 comments Download
M remoting/webapp/plugin_settings.js View 1 chunk +2 lines, -0 lines 0 comments Download
M remoting/webapp/remoting.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
please use gerrit instead
Created Revert of Remove NPAPI plugin from chromoting webapp.
6 years, 6 months ago (2014-06-19 00:48:25 UTC) #1
please use gerrit instead
6 years, 6 months ago (2014-06-19 00:49:27 UTC) #2 
The CQ bit was unchecked by rouslan@chromium.org

Powered by Google App Engine
This is Rietveld 408576698