Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: LayoutTests/editing/execCommand/delete-hidden-crash.html

Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/editing/execCommand/delete-hidden-crash.html
diff --git a/LayoutTests/editing/execCommand/delete-hidden-crash.html b/LayoutTests/editing/execCommand/delete-hidden-crash.html
new file mode 100644
index 0000000000000000000000000000000000000000..0932feb7316658995c87f774ef1dade5d4627c58
--- /dev/null
+++ b/LayoutTests/editing/execCommand/delete-hidden-crash.html
@@ -0,0 +1,40 @@
+<!DOCTYPE html>
+<html>
+<head>
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+
+onload = function(){
Yuta Kitamura 2014/06/18 08:08:11 Space required before the brace.
yosin_UTC9 2014/06/19 07:36:56 Done.
+ document.execCommand('SelectAll')
Yuta Kitamura 2014/06/18 08:08:11 Bad indentation.
yosin_UTC9 2014/06/19 07:36:57 Done.
+ span = document.getElementsByTagName('span')[0];
+ span.contentEditable = 'true';
+ span.textContent = 'bar';
+ document.execCommand('InsertText', false, '1');
+ document.body.textContent = 'PASS if Blink doesn\'t crash.';
+};
+</script>
+<style>
+* { visibility:visible; }
+.inline { display:inline; }
+*:only-child { visibility:hidden; }
+</style>
+</head>
+<body>
+<table>
+ <tbody>
Yuta Kitamura 2014/06/18 08:08:11 Indentation is not necessary here. If you need th
yosin_UTC9 2014/06/19 07:36:56 Done.
+ <tr>
+ <td>
+ <span>
+ <table></table><span></span>
+ </span>
+ </td>
+ </tr>
+ <tr>
+ <td>
+ <td class="inline">
+ foo
+ </tr>
+ </tbody>
Yuta Kitamura 2014/06/18 08:08:11 This test case is very hard to understand... It w
yosin_UTC9 2014/06/19 07:36:56 Done.
+</body>
Yuta Kitamura 2014/06/18 08:08:11 No close tag of <table>?
yosin_UTC9 2014/06/19 07:36:56 Done.
+</html>
« no previous file with comments | « no previous file | LayoutTests/editing/execCommand/delete-hidden-crash-expected.txt » ('j') | Source/core/editing/htmlediting.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698