Chromium Code Reviews (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

Unified Diff: Source/core/editing/htmlediting.h

Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand (Closed) Base URL:
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/htmlediting.h
diff --git a/Source/core/editing/htmlediting.h b/Source/core/editing/htmlediting.h
index 328bddde5db826655eea9f5c9ce82bb0a2943ac2..6da929f22db9624437ef3eaff20d0cb80846d03e 100644
--- a/Source/core/editing/htmlediting.h
+++ b/Source/core/editing/htmlediting.h
@@ -174,7 +174,7 @@ void updatePositionForNodeRemoval(Position&, Node&);
// Functions returning VisiblePosition
VisiblePosition firstEditablePositionAfterPositionInRoot(const Position&, Node*);
-VisiblePosition lastEditablePositionBeforePositionInRoot(const Position&, Node*);
+Position lastEditablePositionBeforePositionInRoot(const Position&, Node*);
Yuta Kitamura 2014/06/18 08:08:11 It's extremely weird to change this function only.
yosin_UTC9 2014/06/19 07:36:57 Make sense. I made another patch
Yuta Kitamura 2014/06/19 07:43:36 Well, self recursion detected in your link ;)
VisiblePosition visiblePositionBeforeNode(Node&);
VisiblePosition visiblePositionAfterNode(Node&);

Powered by Google App Engine
This is Rietveld 408576698