Source/core/editing/htmlediting.h - Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/htmlediting.h

Issue 340713003: Ignore visibility when checking whether Position is editable or not at DeletetSelectionCommand (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/editing/execCommand/delete-hidden-crash.html ('K') | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/editing/htmlediting.cpp » ('j') | Source/core/editing/htmlediting.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/htmlediting.h

diff --git a/Source/core/editing/htmlediting.h b/Source/core/editing/htmlediting.h

index 328bddde5db826655eea9f5c9ce82bb0a2943ac2..6da929f22db9624437ef3eaff20d0cb80846d03e 100644

--- a/Source/core/editing/htmlediting.h

+++ b/Source/core/editing/htmlediting.h

@@ -174,7 +174,7 @@ void updatePositionForNodeRemoval(Position&, Node&);

// Functions returning VisiblePosition

VisiblePosition firstEditablePositionAfterPositionInRoot(const Position&, Node*);

-VisiblePosition lastEditablePositionBeforePositionInRoot(const Position&, Node*);

+Position lastEditablePositionBeforePositionInRoot(const Position&, Node*);

Yuta Kitamura 2014/06/18 08:08:11 It's extremely weird to change this function only.

yosin_UTC9 2014/06/19 07:36:57 Make sense. I made another patch http://crrev.com/

Yuta Kitamura 2014/06/19 07:43:36 Well, self recursion detected in your link ;)

VisiblePosition visiblePositionBeforeNode(Node&);

VisiblePosition visiblePositionAfterNode(Node&);